Sign upLogin

xeroc/python-graphenelib

View on GitHub
Star
graphenebase/ripemd160.py

Summary

Maintainability
B
6 hrs
Test Coverage

File ripemd160.py has 369 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
# Copyright (c) 2021 Pieter Wuille
# Distributed under the MIT software license, see the accompanying
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
Severity: Minor
Found in graphenebase/ripemd160.py - About 4 hrs to fix

    Function compress has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def compress(h0, h1, h2, h3, h4, block):
    Severity: Minor
    Found in graphenebase/ripemd160.py - About 45 mins to fix

      Avoid too many return statements within this function.
      Open

              return x ^ (y | ~z)
      Severity: Major
      Found in graphenebase/ripemd160.py - About 30 mins to fix

        Function fi has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        def fi(x, y, z, i):
    """The f1, f2, f3, f4, and f5 functions from the specification."""
    if i == 0:
        return x ^ y ^ z
    elif i == 1:
        Severity: Minor
        Found in graphenebase/ripemd160.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status