Sign upLogin

xeroc/python-graphenelib

View on GitHub
Star
graphenecommon/chain.py

Summary

Maintainability
C
1 day
Test Coverage

AbstractGrapheneChain has 23 functions (exceeds 20 allowed). Consider refactoring.
Open

class AbstractGrapheneChain:
    def define_classes(self):
        raise NotImplementedError

    def __init__(
Severity: Minor
Found in graphenecommon/chain.py - About 2 hrs to fix

    File chain.py has 257 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    # -*- coding: utf-8 -*-
import logging
from graphenestorage import SqliteConfigurationStore

log = logging.getLogger(__name__)
    Severity: Minor
    Found in graphenecommon/chain.py - About 2 hrs to fix

      Function finalizeOp has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          def finalizeOp(self, ops, account, permission, **kwargs):
        """This method obtains the required private keys if present in
        the wallet, finalizes the transaction, signs it and
        broadacasts it
      Severity: Minor
      Found in graphenecommon/chain.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(
      Severity: Minor
      Found in graphenecommon/chain.py - About 45 mins to fix

        Function new_proposal has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def new_proposal(
        Severity: Minor
        Found in graphenecommon/chain.py - About 35 mins to fix

          Function new_proposal has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def new_proposal(
        self,
        parent=None,
        proposer=None,
        proposal_expiration=None,
          Severity: Minor
          Found in graphenecommon/chain.py - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function connect has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def connect(self, node="", rpcuser="", rpcpassword="", **kwargs):
        """Connect to blockchain network (internal use only)"""
        if not node:
            if "node" in self.config:
                node = self.config["node"]
          Severity: Minor
          Found in graphenecommon/chain.py - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if not rpcuser and "rpcuser" in self.config:
            rpcuser = self.config["rpcuser"]
          Severity: Minor
          Found in graphenecommon/chain.py and 1 other location - About 40 mins to fix
          graphenecommon/chain.py on lines 80..81

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 34.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if not rpcpassword and "rpcpassword" in self.config:
            rpcpassword = self.config["rpcpassword"]
          Severity: Minor
          Found in graphenecommon/chain.py and 1 other location - About 40 mins to fix
          graphenecommon/chain.py on lines 77..78

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 34.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status