Sign upLogin

xjasonlyu/tun2socks

View on GitHub
Star

Showing 39 of 39 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

func WithTCPSACKEnabled(v bool) Option {
    return func(s *stack.Stack) error {
        opt := tcpip.TCPSACKEnabled(v)
        if err := s.SetTransportProtocolOption(tcp.ProtocolNumber, &opt); err != nil {
            return fmt.Errorf("set TCP SACK: %s", err)
Severity: Major
Found in core/option/option.go and 3 other locations - About 45 mins to fix
core/option/option.go on lines 207..215
core/option/option.go on lines 218..226
core/option/option.go on lines 229..237

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 113.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

func WithTCPDelay(v bool) Option {
    return func(s *stack.Stack) error {
        opt := tcpip.TCPDelayEnabled(v)
        if err := s.SetTransportProtocolOption(tcp.ProtocolNumber, &opt); err != nil {
            return fmt.Errorf("set TCP delay: %s", err)
Severity: Major
Found in core/option/option.go and 3 other locations - About 45 mins to fix
core/option/option.go on lines 207..215
core/option/option.go on lines 229..237
core/option/option.go on lines 240..248

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 113.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if choice, ok := aeadList[name]; ok {
        if len(key) == 0 {
            key = Kdf(password, choice.KeySize)
        }
        if len(key) != choice.KeySize {
Severity: Minor
Found in transport/shadowsocks/core/cipher.go and 1 other location - About 40 mins to fix
transport/shadowsocks/core/cipher.go on lines 109..118

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if choice, ok := streamList[name]; ok {
        if len(key) == 0 {
            key = Kdf(password, choice.KeySize)
        }
        if len(key) != choice.KeySize {
Severity: Minor
Found in transport/shadowsocks/core/cipher.go and 1 other location - About 40 mins to fix
transport/shadowsocks/core/cipher.go on lines 98..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function getConnections has 6 return statements (exceeds 4 allowed).
Open

func getConnections(w http.ResponseWriter, r *http.Request) {
    if !websocket.IsWebSocketUpgrade(r) {
        render.JSON(w, r, statistic.DefaultManager.Snapshot())
        return
    }
Severity: Major
Found in restapi/connections.go - About 40 mins to fix

    Method Reader.read has 6 return statements (exceeds 4 allowed).
    Open

    func (r *Reader) read(p []byte) (int, error) {
    nonce := r.nonce[:r.NonceSize()]
    tag := r.Overhead()

    // decrypt payload size
    Severity: Major
    Found in transport/shadowsocks/shadowaead/stream.go - About 40 mins to fix

      Function ReadAddr has 6 return statements (exceeds 4 allowed).
      Open

      func ReadAddr(r io.Reader, b []byte) (Addr, error) {
    if len(b) < MaxAddrLen {
        return nil, io.ErrShortBuffer
    }
      Severity: Major
      Found in transport/socks5/socks5.go - About 40 mins to fix

        Function Open has 6 return statements (exceeds 4 allowed).
        Open

        func Open(name string, mtu uint32) (device.Device, error) {
    t := &TUN{name: name, mtu: mtu}

    if len(t.name) >= unix.IFNAMSIZ {
        return nil, fmt.Errorf("interface name too long: %s", t.name)
        Severity: Major
        Found in core/device/tun/tun_netstack.go - About 40 mins to fix

          Method emitter.Emit has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          func (emitter) Emit(depth int, level glog.Level, _ time.Time, format string, args ...any) {
          Severity: Minor
          Found in log/emitter.go - About 35 mins to fix

            Method Addr.Valid has 5 return statements (exceeds 4 allowed).
            Open

            func (a Addr) Valid() bool {
    if len(a) < 1+1+2 /* minimum length */ {
        return false
    }
            Severity: Major
            Found in transport/socks5/socks5.go - About 35 mins to fix

              Function setSocketOptions has 5 return statements (exceeds 4 allowed).
              Open

              func setSocketOptions(network, address string, c syscall.RawConn, opts *Options) (err error) {
    if opts == nil || !isTCPSocket(network) && !isUDPSocket(network) {
        return
    }
              Severity: Major
              Found in dialer/sockopt_linux.go - About 35 mins to fix

                Method TLSObfs.read has 5 return statements (exceeds 4 allowed).
                Open

                func (to *TLSObfs) read(b []byte, discardN int) (int, error) {
    buf := pool.Get(discardN)
    _, err := io.ReadFull(to.Conn, buf)
    if err != nil {
        return 0, err
                Severity: Major
                Found in transport/simple-obfs/tls.go - About 35 mins to fix

                  Function ClientHandshake has 5 return statements (exceeds 4 allowed).
                  Open

                  func ClientHandshake(rw io.ReadWriter, addr string, command Command, userID string) (err error) {
    var (
        host string
        port uint16
    )
                  Severity: Major
                  Found in transport/socks4/socks4.go - About 35 mins to fix

                    Method relayConn.Read has 5 return statements (exceeds 4 allowed).
                    Open

                    func (rc *relayConn) Read(b []byte) (n int, err error) {
    rc.once.Do(func() {
        if rc.wbuf != nil {
            err = readRelayResponse(rc.Conn)
        }
                    Severity: Major
                    Found in proxy/relay.go - About 35 mins to fix

                      Function Unpack has 5 return statements (exceeds 4 allowed).
                      Open

                      func Unpack(dst, pkt []byte, ciph Cipher) ([]byte, error) {
    saltSize := ciph.SaltSize()
    if len(pkt) < saltSize {
        return nil, ErrShortPacket
    }
                      Severity: Major
                      Found in transport/shadowsocks/shadowaead/packet.go - About 35 mins to fix

                        Function PickCipher has 5 return statements (exceeds 4 allowed).
                        Open

                        func PickCipher(name string, key []byte, password string) (Cipher, error) {
    name = strings.ToUpper(name)

    switch name {
    case "DUMMY":
                        Severity: Major
                        Found in transport/shadowsocks/core/cipher.go - About 35 mins to fix

                          Method HTTPObfs.Read has 5 return statements (exceeds 4 allowed).
                          Open

                          func (ho *HTTPObfs) Read(b []byte) (int, error) {
    if ho.buf != nil {
        n := copy(b, ho.buf[ho.offset:])
        ho.offset += n
        if ho.offset == len(ho.buf) {
                          Severity: Major
                          Found in transport/simple-obfs/http.go - About 35 mins to fix

                            Function netstack has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
                            Open

                            func netstack(k *Key) (err error) {
    if k.Proxy == "" {
        return errors.New("empty proxy")
    }
    if k.Device == "" {
                            Severity: Minor
                            Found in engine/engine.go - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function setSocketOptions has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
                            Open

                            func setSocketOptions(network, address string, c syscall.RawConn, opts *Options) (err error) {
    if opts == nil || !isTCPSocket(network) && !isUDPSocket(network) {
        return
    }
                            Severity: Minor
                            Found in dialer/sockopt_darwin.go - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language