transport/socks5/socks5.go
Function ClientHandshake has 14 return statements (exceeds 4 allowed). Open
Open
func ClientHandshake(rw io.ReadWriter, addr Addr, command Command, user *User) (Addr, error) {
buf := make([]byte, MaxAddrLen)
var method uint8
if user != nil {Function ClientHandshake has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring. Open
Open
func ClientHandshake(rw io.ReadWriter, addr Addr, command Command, user *User) (Addr, error) {
buf := make([]byte, MaxAddrLen)
var method uint8
if user != nil {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function ReadAddr has 6 return statements (exceeds 4 allowed). Open
Open
func ReadAddr(r io.Reader, b []byte) (Addr, error) {
if len(b) < MaxAddrLen {
return nil, io.ErrShortBuffer
}
Method Addr.Valid has 5 return statements (exceeds 4 allowed). Open
Open
func (a Addr) Valid() bool {
if len(a) < 1+1+2 /* minimum length */ {
return false
}