Sign upLogin

xlab-si/xopera-opera

View on GitHub
Star
src/opera/instance/base.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def run(self, operation, host: OperationHost, verbose, workdir, validate):
        # TODO: Respect the timeout option.
        # TODO: Add host validation.
        # TODO: Properly handle SELF - not even sure what this proper way would be at this time.
        actual_host = self.get_host(operation.host or host)
Severity: Minor
Found in src/opera/instance/base.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function run_operation has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def run_operation(self,
Severity: Minor
Found in src/opera/instance/base.py - About 45 mins to fix

    Function run has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def run(self, operation, host: OperationHost, verbose, workdir, validate):
    Severity: Minor
    Found in src/opera/instance/base.py - About 35 mins to fix

      Function run_operation has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def run_operation(self,
                      host: OperationHost,
                      interface: str,
                      operation_type: Union[StandardInterfaceOperation, ConfigureInterfaceOperation],
                      verbose: bool,
      Severity: Minor
      Found in src/opera/instance/base.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status