Sign upLogin

xlab-si/xopera-opera

View on GitHub
Star
src/opera/instance/relationship.py

Summary

Maintainability
C
1 day
Test Coverage

Function get_attribute has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    def get_attribute(self, params):
        host, attr, *rest = params

        if host == OperationHost.SELF.value:
            # TODO: Add support for nested attribute values once we have data type support.
Severity: Minor
Found in src/opera/instance/relationship.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_property has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

    def get_property(self, params):
        host, prop, *rest = params

        if host == OperationHost.SOURCE.value:
            return self.source.get_property([OperationHost.SELF.value, prop] + rest)
Severity: Minor
Found in src/opera/instance/relationship.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, template, topology, instance_id, source=None, target=None):
Severity: Minor
Found in src/opera/instance/relationship.py - About 35 mins to fix

    Avoid too many return statements within this function.
    Open

                            return rel.attributes[attr].eval(self, attr)
    Severity: Major
    Found in src/opera/instance/relationship.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                              return rel.template.properties[prop].eval(self, prop)
      Severity: Major
      Found in src/opera/instance/relationship.py - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status