Sign upLogin

xmidt-org/themis

View on GitHub
Star
key/pair.go

Summary

Maintainability
B
6 hrs
Test Coverage

Function NewPair has 82 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func NewPair(kid string, key interface{}) (Pair, error) {
    switch k := key.(type) {
    case *rsa.PrivateKey:
        verifyPEM, err := MarshalPKIXPublicKeyToPEM(&k.PublicKey)
        if err != nil {
Severity: Major
Found in key/pair.go - About 2 hrs to fix

    Function NewPair has 15 return statements (exceeds 4 allowed).
    Open

    func NewPair(kid string, key interface{}) (Pair, error) {
    switch k := key.(type) {
    case *rsa.PrivateKey:
        verifyPEM, err := MarshalPKIXPublicKeyToPEM(&k.PublicKey)
        if err != nil {
    Severity: Major
    Found in key/pair.go - About 1 hr to fix

      Function NewPair has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
      Open

      func NewPair(kid string, key interface{}) (Pair, error) {
    switch k := key.(type) {
    case *rsa.PrivateKey:
        verifyPEM, err := MarshalPKIXPublicKeyToPEM(&k.PublicKey)
        if err != nil {
      Severity: Minor
      Found in key/pair.go - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          case *rsa.PrivateKey:
        verifyPEM, err := MarshalPKIXPublicKeyToPEM(&k.PublicKey)
        if err != nil {
            return nil, err
        }
      Severity: Major
      Found in key/pair.go and 1 other location - About 1 hr to fix
      key/pair.go on lines 91..111

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 131.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          case *ecdsa.PrivateKey:
        verifyPEM, err := MarshalPKIXPublicKeyToPEM(&k.PublicKey)
        if err != nil {
            return nil, err
        }
      Severity: Major
      Found in key/pair.go and 1 other location - About 1 hr to fix
      key/pair.go on lines 69..89

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 131.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status