xmidt-org/themis

View on GitHub
xmetrics/xmetricshttp/provide.go

Summary

Maintainability
C
1 day
Test Coverage

Similar blocks of code found in 6 locations. Consider refactoring.
Open

func ProvideRoundTripperCounter(o prometheus.CounterOpts, l *ClientLabellers) fx.Annotated {
    return fx.Annotated{
        Name: o.Name,
        Target: func(f xmetrics.Factory) (RoundTripperCounter, error) {
            c, err := f.NewCounterVec(o, l.LabelNames())
Severity: Major
Found in xmetrics/xmetricshttp/provide.go and 5 other locations - About 1 hr to fix
xmetrics/xmetricshttp/provide.go on lines 10..25
xmetrics/xmetricshttp/provide.go on lines 27..42
xmetrics/xmetricshttp/provide.go on lines 44..59
xmetrics/xmetricshttp/provide.go on lines 94..109
xmetrics/xmetricshttp/provide.go on lines 111..126

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 153.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

func ProvideHandlerDurationSummary(o prometheus.SummaryOpts, l *ServerLabellers) fx.Annotated {
    return fx.Annotated{
        Name: o.Name,
        Target: func(f xmetrics.Factory) (HandlerDuration, error) {
            s, err := f.NewSummaryVec(o, l.LabelNames())
Severity: Major
Found in xmetrics/xmetricshttp/provide.go and 5 other locations - About 1 hr to fix
xmetrics/xmetricshttp/provide.go on lines 10..25
xmetrics/xmetricshttp/provide.go on lines 27..42
xmetrics/xmetricshttp/provide.go on lines 77..92
xmetrics/xmetricshttp/provide.go on lines 94..109
xmetrics/xmetricshttp/provide.go on lines 111..126

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 153.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

func ProvideRoundTripperDurationHistogram(o prometheus.HistogramOpts, l *ClientLabellers) fx.Annotated {
    return fx.Annotated{
        Name: o.Name,
        Target: func(f xmetrics.Factory) (RoundTripperDuration, error) {
            h, err := f.NewHistogramVec(o, l.LabelNames())
Severity: Major
Found in xmetrics/xmetricshttp/provide.go and 5 other locations - About 1 hr to fix
xmetrics/xmetricshttp/provide.go on lines 10..25
xmetrics/xmetricshttp/provide.go on lines 27..42
xmetrics/xmetricshttp/provide.go on lines 44..59
xmetrics/xmetricshttp/provide.go on lines 77..92
xmetrics/xmetricshttp/provide.go on lines 111..126

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 153.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

func ProvideRoundTripperDurationSummary(o prometheus.SummaryOpts, l *ClientLabellers) fx.Annotated {
    return fx.Annotated{
        Name: o.Name,
        Target: func(f xmetrics.Factory) (RoundTripperDuration, error) {
            s, err := f.NewSummaryVec(o, l.LabelNames())
Severity: Major
Found in xmetrics/xmetricshttp/provide.go and 5 other locations - About 1 hr to fix
xmetrics/xmetricshttp/provide.go on lines 10..25
xmetrics/xmetricshttp/provide.go on lines 27..42
xmetrics/xmetricshttp/provide.go on lines 44..59
xmetrics/xmetricshttp/provide.go on lines 77..92
xmetrics/xmetricshttp/provide.go on lines 94..109

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 153.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

func ProvideHandlerCounter(o prometheus.CounterOpts, l *ServerLabellers) fx.Annotated {
    return fx.Annotated{
        Name: o.Name,
        Target: func(f xmetrics.Factory) (HandlerCounter, error) {
            c, err := f.NewCounterVec(o, l.LabelNames())
Severity: Major
Found in xmetrics/xmetricshttp/provide.go and 5 other locations - About 1 hr to fix
xmetrics/xmetricshttp/provide.go on lines 27..42
xmetrics/xmetricshttp/provide.go on lines 44..59
xmetrics/xmetricshttp/provide.go on lines 77..92
xmetrics/xmetricshttp/provide.go on lines 94..109
xmetrics/xmetricshttp/provide.go on lines 111..126

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 153.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

func ProvideHandlerDurationHistogram(o prometheus.HistogramOpts, l *ServerLabellers) fx.Annotated {
    return fx.Annotated{
        Name: o.Name,
        Target: func(f xmetrics.Factory) (HandlerDuration, error) {
            h, err := f.NewHistogramVec(o, l.LabelNames())
Severity: Major
Found in xmetrics/xmetricshttp/provide.go and 5 other locations - About 1 hr to fix
xmetrics/xmetricshttp/provide.go on lines 10..25
xmetrics/xmetricshttp/provide.go on lines 44..59
xmetrics/xmetricshttp/provide.go on lines 77..92
xmetrics/xmetricshttp/provide.go on lines 94..109
xmetrics/xmetricshttp/provide.go on lines 111..126

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 153.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func ProvideHandlerInFlight(o prometheus.GaugeOpts) fx.Annotated {
    return fx.Annotated{
        Name: o.Name,
        Target: func(f xmetrics.Factory) (HandlerInFlight, error) {
            g, err := f.NewGaugeVec(o, nil)
Severity: Major
Found in xmetrics/xmetricshttp/provide.go and 1 other location - About 1 hr to fix
xmetrics/xmetricshttp/provide.go on lines 128..142

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 135.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func ProvideRoundTripperInFlight(o prometheus.GaugeOpts) fx.Annotated {
    return fx.Annotated{
        Name: o.Name,
        Target: func(f xmetrics.Factory) (RoundTripperInFlight, error) {
            g, err := f.NewGaugeVec(o, nil)
Severity: Major
Found in xmetrics/xmetricshttp/provide.go and 1 other location - About 1 hr to fix
xmetrics/xmetricshttp/provide.go on lines 61..75

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 135.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status