xmidt-org/wrp-go

View on GitHub

Showing 224 of 224 total issues

Function ParseLocator has 5 return statements (exceeds 4 allowed).
Open

func ParseLocator(locator string) (Locator, error) {
    match := LocatorPattern.FindStringSubmatch(locator)
    if match == nil {
        return Locator{}, ErrorInvalidLocator
    }
Severity: Major
Found in id.go - About 35 mins to fix

    Function FormatFromContentType has 5 return statements (exceeds 4 allowed).
    Open

    func FormatFromContentType(contentType string, fallback ...Format) (Format, error) {
        if len(contentType) == 0 {
            if len(fallback) > 0 {
                return fallback[0], nil
            }
    Severity: Major
    Found in format.go - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (vt *validatorLevel) UnmarshalText(b []byte) error {
          s := strings.ToLower(string(b))
          r, ok := validatorLevelUnmarshal[s]
          if !ok {
              return fmt.Errorf("ValidatorLevel error: '%s' does not match any valid options: %s",
      Severity: Minor
      Found in wrpvalidator/validatorLevel.go and 1 other location - About 30 mins to fix
      wrpvalidator/validatorType.go on lines 81..91

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 102.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (vt *validatorType) UnmarshalText(b []byte) error {
          s := strings.ToLower(string(b))
          r, ok := validatorTypeUnmarshal[s]
          if !ok {
              return fmt.Errorf("ValidatorType error: '%s' does not match any valid options: %s",
      Severity: Minor
      Found in wrpvalidator/validatorType.go and 1 other location - About 30 mins to fix
      wrpvalidator/validatorLevel.go on lines 58..68

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 102.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language