Sign upLogin

xolvio/pojo-observer

View on GitHub
Star

Showing 28 of 28 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  function ComponentUsingModel2({model}: {model: typeof obj2}) {
    useObserver(model)

    return (
      <div>
Severity: Major
Found in src/useObserver.spec.tsx and 1 other location - About 1 hr to fix
src/useObserver.spec.tsx on lines 163..171

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 74.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function attachProxyToArray has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function attachProxyToArray(object, fieldName, callback, id): void {
  object[fieldName].forEach((element, index) => {
    // eslint-disable-next-line @typescript-eslint/no-use-before-define
    recursivelyAttachProxy(element, index, object[fieldName], id, callback)
  })
Severity: Minor
Found in src/useObserver.ts - About 1 hr to fix

    Function attachProxyToArray has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    function attachProxyToArray(object, fieldName, callback, id): void {
  object[fieldName].forEach((element, index) => {
    // eslint-disable-next-line @typescript-eslint/no-use-before-define
    recursivelyAttachProxy(element, index, object[fieldName], id, callback)
  })
    Severity: Minor
    Found in src/useObserver.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function FileTree has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const FileTree: React.FC<IFileTree> = (props: Props) => {
  const {fileTree} = props
  useObserver(fileTree)

  function loadFiles(): void {
    Severity: Minor
    Found in example/src/components/FileTree.tsx - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

        class TestClass {
    current = 2

    previous(): void {
      this.current--
      Severity: Minor
      Found in src/useObserver.spec.tsx and 1 other location - About 50 mins to fix
      src/useObserver.spec.tsx on lines 201..211

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

        class TestClass {
    current = 2

    previous(): void {
      this.current--
      Severity: Minor
      Found in src/useObserver.spec.tsx and 1 other location - About 50 mins to fix
      src/useObserver.spec.tsx on lines 9..19

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function recursivelyAttachProxy has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        originalField,
  fieldName,
  object,
  id,
  callback: Function
      Severity: Minor
      Found in src/useObserver.ts - About 35 mins to fix

        Function attachProxyToField has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          object,
  fieldName,
  originalField,
  callback,
  id
        Severity: Minor
        Found in src/useObserver.ts - About 35 mins to fix
          Severity
          Category
          Status
          Source
          Language