xoopscube/altsys

View on GitHub

Showing 115 of 162 total issues

Method tplsadmin_copy_templates_db2db has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function tplsadmin_copy_templates_db2db( $tplset_from, $tplset_to, $whr_append = '1' ) {
    global $db;

    // get tplfile and tplsource

Severity: Minor
Found in xoops_trust_path/libs/altsys/include/tpls_functions.php - About 1 hr to fix

    Method draw_repost_form has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            public function draw_repost_form(string $area = '' ) {
                // Notify which file is broken
    
                if ( headers_sent() ) {
                    restore_error_handler();
    Severity: Minor
    Found in xoops_trust_path/libs/altsys/include/gtickets.php - About 1 hr to fix

      Method render has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function render() {
              $ret = '';
      
              if ( count( $this->_appendix ) > 0 ) {
                  $ret  .= '<table class="outer"><tr>';
      Severity: Minor
      Found in xoops_trust_path/libs/altsys/include/mygrouppermform.php - About 1 hr to fix

        Function tplsadmin_get_basefilepath has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

        function tplsadmin_get_basefilepath( $dirname, $type, $tpl_file ) {
            $mytrustdirname = null;
         // module instance
        
            $path = $basefilepath = XOOPS_ROOT_PATH . '/modules/' . $dirname . '/templates/' . ( 'block' == $type ? 'blocks/' : '' ) . $tpl_file;
        Severity: Minor
        Found in xoops_trust_path/libs/altsys/include/tpls_functions.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get_view_edit has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            public function get_view_edit()
            {
                $id = $this->init_default_values();
        
                $lines = [];
        Severity: Minor
        Found in xoops_trust_path/libs/altsys/class/d3utilities.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method tplsadmin_copy_templates_f2db has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function tplsadmin_copy_templates_f2db( $tplset_to, $whr_append = '1' ) {
            global $db;
        
            // get tplsource
            //$result = $db->query('SELECT * FROM ' . $db->prefix('tplfile') . "  WHERE tpl_tplset='default' AND ($whr_append)") ;
        Severity: Minor
        Found in xoops_trust_path/libs/altsys/include/tpls_functions.php - About 1 hr to fix

          Method tplsadmin_import_data has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function tplsadmin_import_data( $tplset, $tpl_file, $tpl_source, $lastmodified = 0 ) {
          
              $db =& XoopsDatabaseFactory::getDatabaseConnection();
          
              // check the file is valid template
          Severity: Minor
          Found in xoops_trust_path/libs/altsys/include/tpls_functions.php - About 1 hr to fix

            Method init has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function init( $xoopsModule ) {
                    $target_module = null;
              // altsys "module" MODE
            
                    if ( 'altsys' == $xoopsModule->getVar( 'dirname' ) ) {
            Severity: Minor
            Found in xoops_trust_path/libs/altsys/class/MyBlocksAdmin.class.php - About 1 hr to fix

              Function render has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function render() {
                      global $xoopsGTicket;
              
                      // load all child ids for javascript codes
                      foreach ( array_keys( $this->_itemTree ) as $item_id ) {
              Severity: Minor
              Found in xoops_trust_path/libs/altsys/include/mygrouppermform.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function render has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function render() {
                      $ret = '';
              
                      if ( count( $this->_appendix ) > 0 ) {
                          $ret  .= '<table class="outer"><tr>';
              Severity: Minor
              Found in xoops_trust_path/libs/altsys/include/mygrouppermform.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function form_edit has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function form_edit( $bid, $mode = 'edit' ) {
                      $bid = (int) $bid;
              
                      //HACK by domifara
                      if ( defined( 'XOOPS_CUBE_LEGACY' ) ) {
              Severity: Minor
              Found in xoops_trust_path/libs/altsys/class/MyBlocksAdmin.class.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getDelegateCallbackClassNames has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static function getDelegateCallbackClassNames($name, bool $doRegist = true)
                  {
                      $names = [];
              
                      if (!class_exists('XCube_Delegate')) {
              Severity: Minor
              Found in xoops_trust_path/libs/altsys/class/altsysUtils.class.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method get_view_edit has 35 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function get_view_edit()
                  {
                      $id = $this->init_default_values();
              
                      $lines = [];
              Severity: Minor
              Found in xoops_trust_path/libs/altsys/class/d3utilities.php - About 1 hr to fix

                Method _renderOptionTree has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function _renderOptionTree( &$tree, $option, $prefix, $parentIds = [] ) {
                        $tree .= $prefix . '<input type="checkbox" name="' . $this->getName() . '[groups][' . $this->_groupId . '][' . $option['id'] . ']" id="' . $this->getName() . '[groups][' . $this->_groupId . '][' . $option['id'] . ']" onclick="';
                        // If there are parent elements, add javascript that will
                        // make them selected when this element is checked to make
                        // sure permissions to parent items are added as well.
                Severity: Minor
                Found in xoops_trust_path/libs/altsys/include/mygrouppermform.php - About 1 hr to fix

                  Method update has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function update()
                      {
                          $db =& XoopsDatabaseFactory::getDatabaseConnection();
                  
                          // search appropriate column for getting primary_key
                  Severity: Minor
                  Found in xoops_trust_path/libs/altsys/class/d3utilities.php - About 1 hr to fix

                    Method _compareseq has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function _compareseq( $xoff, $xlim, $yoff, $ylim ) {
                            $seps = [];
                      /* Slide down the bottom initial diagonal. */
                            while ( $xoff < $xlim && $yoff < $ylim
                                    && $this->xv[ $xoff ] == $this->yv[ $yoff ] ) {
                    Severity: Minor
                    Found in xoops_trust_path/libs/altsys/include/Text_Diff.php - About 1 hr to fix

                      Function do_clone has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function do_clone( $bid ) {
                              $handler = null;
                        $bid = (int) $bid;
                      
                              $request = $this->fetchRequest4Block( $bid );
                      Severity: Minor
                      Found in xoops_trust_path/libs/altsys/class/MyBlocksAdmin.class.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function insert has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function insert()
                          {
                              $db =& XoopsDatabaseFactory::getDatabaseConnection();
                      
                              $id = $this->init_default_values();
                      Severity: Minor
                      Found in xoops_trust_path/libs/altsys/class/d3utilities.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function init_default_values has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function init_default_values(): int
                          {
                              $db =& XoopsDatabaseFactory::getDatabaseConnection();
                      
                              if (@$_GET['id']) {
                      Severity: Minor
                      Found in xoops_trust_path/libs/altsys/class/d3utilities.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function canClone has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function canClone( $block ) {
                              // can clone link if it is marked as cloneable block
                              if ( 'D' == $block->getVar( 'block_type' ) || 'C' == $block->getVar( 'block_type' ) ) {
                                  return 2;
                              }
                      Severity: Minor
                      Found in xoops_trust_path/libs/altsys/class/MyBlocksAdmin.class.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language