Sign upLogin

xprt64/cqrs-es

View on GitHub
Star

Showing 34 of 34 total issues

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    public function __construct(
        CommandSubscriber $commandSubscriber,
        CommandApplier $commandApplier,
        EventSourcedAggregateRepository $aggregateRepository,
        EventsApplierOnAggregate $eventsApplier,
Severity: Major
Found in src/Dudulina/Command/CommandTester/DefaultCommandTester.php and 2 other locations - About 1 hr to fix
src/Dudulina/Command/CommandTester/DefaultCommandTesterWithExplanation.php on lines 50..65
src/Dudulina/Command/CommandTester/DefaultCommandTesterWithSideEffect.php on lines 51..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 100.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

<?php
/**
 * Copyright (c) 2018 Constantin Galbenu <xprt64@gmail.com>
 */
Severity: Major
Found in src/Dudulina/CodeGeneration/Event/ReadModelsMapCodeGenerator.php and 3 other locations - About 1 hr to fix
src/Dudulina/CodeGeneration/Command/CommandValidatorsMapCodeGenerator.php on lines 1..33
src/Dudulina/CodeGeneration/Event/EventListenersMapCodeGenerator.php on lines 1..34
src/Dudulina/CodeGeneration/Event/SagaEventProcessorsMapCodeGenerator.php on lines 1..35

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 100.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

<?php
/**
 * Copyright (c) 2018 Constantin Galbenu <xprt64@gmail.com>
 */
Severity: Major
Found in src/Dudulina/CodeGeneration/Command/CommandValidatorsMapCodeGenerator.php and 3 other locations - About 1 hr to fix
src/Dudulina/CodeGeneration/Event/EventListenersMapCodeGenerator.php on lines 1..34
src/Dudulina/CodeGeneration/Event/ReadModelsMapCodeGenerator.php on lines 1..33
src/Dudulina/CodeGeneration/Event/SagaEventProcessorsMapCodeGenerator.php on lines 1..35

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 100.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    public function __construct(
        CommandSubscriber $commandSubscriber,
        CommandApplier $commandApplier,
        EventSourcedAggregateRepository $aggregateRepository,
        EventsApplierOnAggregate $eventsApplier,
Severity: Major
Found in src/Dudulina/Command/CommandTester/DefaultCommandTesterWithSideEffect.php and 2 other locations - About 1 hr to fix
src/Dudulina/Command/CommandTester/DefaultCommandTester.php on lines 51..66
src/Dudulina/Command/CommandTester/DefaultCommandTesterWithExplanation.php on lines 50..65

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 100.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

<?php
/**
 * Copyright (c) 2018 Constantin Galbenu <xprt64@gmail.com>
 */
Severity: Major
Found in src/Dudulina/CodeGeneration/Event/EventListenersMapCodeGenerator.php and 3 other locations - About 1 hr to fix
src/Dudulina/CodeGeneration/Command/CommandValidatorsMapCodeGenerator.php on lines 1..33
src/Dudulina/CodeGeneration/Event/ReadModelsMapCodeGenerator.php on lines 1..33
src/Dudulina/CodeGeneration/Event/SagaEventProcessorsMapCodeGenerator.php on lines 1..35

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 100.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    public function __construct(
        CommandSubscriber $commandSubscriber,
        CommandApplier $commandApplier,
        EventSourcedAggregateRepository $aggregateRepository,
        EventsApplierOnAggregate $eventsApplier,
Severity: Major
Found in src/Dudulina/Command/CommandTester/DefaultCommandTesterWithExplanation.php and 2 other locations - About 1 hr to fix
src/Dudulina/Command/CommandTester/DefaultCommandTester.php on lines 51..66
src/Dudulina/Command/CommandTester/DefaultCommandTesterWithSideEffect.php on lines 51..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 100.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

<?php
/**
 * Copyright (c) 2018 Constantin Galbenu <xprt64@gmail.com>
 */
Severity: Major
Found in src/Dudulina/CodeGeneration/Event/SagaEventProcessorsMapCodeGenerator.php and 3 other locations - About 1 hr to fix
src/Dudulina/CodeGeneration/Command/CommandValidatorsMapCodeGenerator.php on lines 1..33
src/Dudulina/CodeGeneration/Event/EventListenersMapCodeGenerator.php on lines 1..34
src/Dudulina/CodeGeneration/Event/ReadModelsMapCodeGenerator.php on lines 1..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 100.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        CommandSubscriber $commandSubscriber,
        CommandApplier $commandApplier,
        EventSourcedAggregateRepository $aggregateRepository,
        EventsApplierOnAggregate $eventsApplier,
        EventMetadataFactory $eventMetadataFactory,
Severity: Minor
Found in src/Dudulina/Command/CommandTester/DefaultCommandTesterWithSideEffect.php - About 45 mins to fix

    Function thenShouldFailWith has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function thenShouldFailWith($exceptionClass, $message = null)
    {
        $this->checkCommand($this->command);

        try {
    Severity: Minor
    Found in src/Dudulina/Testing/BddAggregateTestHelper.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            CommandSubscriber $commandSubscriber,
        CommandApplier $commandApplier,
        EventSourcedAggregateRepository $aggregateRepository,
        EventsApplierOnAggregate $eventsApplier,
        EventMetadataFactory $eventMetadataFactory,
    Severity: Minor
    Found in src/Dudulina/Command/CommandTester/DefaultCommandTesterWithExplanation.php - About 45 mins to fix

      Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              CommandSubscriber $commandSubscriber,
        CommandApplier $commandApplier,
        EventSourcedAggregateRepository $aggregateRepository,
        EventsApplierOnAggregate $eventsApplier,
        EventMetadataFactory $eventMetadataFactory,
      Severity: Minor
      Found in src/Dudulina/Command/CommandTester/DefaultCommandTester.php - About 45 mins to fix

        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                $aggregateId,
        string $aggregateClass,
        \DateTimeImmutable $dateCreated,
        $authenticatedUserId = null,
        $commandMetadata = null
        Severity: Minor
        Found in src/Dudulina/Event/MetaData.php - About 35 mins to fix

          Method loadTemplate has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function loadTemplate(string $content, string $templateClassName, string $templateNamespace, string $outputShortClassName, string $outputNamespace)
          Severity: Minor
          Found in src/Dudulina/CodeGeneration/TemplateLoader.php - About 35 mins to fix

            Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    EventStore $eventStore,
        LoggerInterface $logger,
        TailableEventStream $tailableEventStream,
        ReadModelEventApplier $readModelEventApplier,
        ReadModelReflector $readModelReflector
            Severity: Minor
            Found in src/Dudulina/ReadModel/ReadModelTail.php - About 35 mins to fix
              Severity
              Category
              Status
              Source
              Language