Sign upLogin

xptavares/activerequest

View on GitHub
Star
lib/active_request/has_many.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method build_has_manys has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

      def build_has_manys(alloc)
        alloc.has_manys.each do |many|
          alloc.instance_variable_set("@#{many[:association]}", [])
          define_method(many[:association]) do
            variable = alloc.instance_variable_get("@#{many[:association]}")
Severity: Minor
Found in lib/active_request/has_many.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method build_has_manys has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def build_has_manys(alloc)
        alloc.has_manys.each do |many|
          alloc.instance_variable_set("@#{many[:association]}", [])
          define_method(many[:association]) do
            variable = alloc.instance_variable_get("@#{many[:association]}")
Severity: Minor
Found in lib/active_request/has_many.rb - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status