Sign upLogin

xwp/stream

View on GitHub
Star
connectors/class-connector-edd.php

Summary

Maintainability
F
4 days
Test Coverage
D
62%

File class-connector-edd.php has 391 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Connector for Easy Digital Downloads
 *
 * @package WP_Stream
Severity: Minor
Found in connectors/class-connector-edd.php - About 5 hrs to fix

    Connector_EDD has 29 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Connector_EDD extends Connector {

    /**
     * Connector slug
     *
    Severity: Minor
    Found in connectors/class-connector-edd.php - About 3 hrs to fix

      Function check_edd_settings has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

          public function check_edd_settings( $old_value, $new_value ) {
        $options = array();

        if ( ! is_array( $old_value ) || ! is_array( $new_value ) ) {
            return;
      Severity: Minor
      Found in connectors/class-connector-edd.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method action_links has 74 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function action_links( $links, $record ) {
        if ( in_array( $record->context, array( 'downloads' ), true ) ) {
            $posts_connector = new Connector_Posts();
            $links           = $posts_connector->action_links( $links, $record );
        } elseif ( in_array( $record->context, array( 'discounts' ), true ) ) {
      Severity: Major
      Found in connectors/class-connector-edd.php - About 2 hrs to fix

        Consider simplifying this complex logical expression.
        Open

                if ( 'posts' === $data['connector'] && 'download' === $data['context'] ) {
            // Download posts operations.
            $data['context']   = 'downloads';
            $data['connector'] = $this->name;
        } elseif ( 'posts' === $data['connector'] && 'edd_discount' === $data['context'] ) {
        Severity: Critical
        Found in connectors/class-connector-edd.php - About 2 hrs to fix

          Function log_override has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

              public function log_override( $data ) {
        if ( ! is_array( $data ) ) {
            return $data;
        }
          Severity: Minor
          Found in connectors/class-connector-edd.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method check_edd_settings has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function check_edd_settings( $old_value, $new_value ) {
        $options = array();

        if ( ! is_array( $old_value ) || ! is_array( $new_value ) ) {
            return;
          Severity: Minor
          Found in connectors/class-connector-edd.php - About 1 hr to fix

            Method log_override has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function log_override( $data ) {
        if ( ! is_array( $data ) ) {
            return $data;
        }
            Severity: Minor
            Found in connectors/class-connector-edd.php - About 1 hr to fix

              Function action_links has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function action_links( $links, $record ) {
        if ( in_array( $record->context, array( 'downloads' ), true ) ) {
            $posts_connector = new Connector_Posts();
            $links           = $posts_connector->action_links( $links, $record );
        } elseif ( in_array( $record->context, array( 'discounts' ), true ) ) {
              Severity: Minor
              Found in connectors/class-connector-edd.php - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this method.
              Open

                          return false;
              Severity: Major
              Found in connectors/class-connector-edd.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return false; // Do not track notes, because they're basically logs.
                Severity: Major
                Found in connectors/class-connector-edd.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return false;
                  Severity: Major
                  Found in connectors/class-connector-edd.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return $data;
                    Severity: Major
                    Found in connectors/class-connector-edd.php - About 30 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              return array(
            'created'   => esc_html_x( 'Created', 'edd', 'stream' ),
            'updated'   => esc_html_x( 'Updated', 'edd', 'stream' ),
            'added'     => esc_html_x( 'Added', 'edd', 'stream' ),
            'deleted'   => esc_html_x( 'Deleted', 'edd', 'stream' ),
                      Severity: Major
                      Found in connectors/class-connector-edd.php and 1 other location - About 5 hrs to fix
                      connectors/class-connector-wordpress-seo.php on lines 583..594

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 183.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          public function get_context_labels() {
        return array(
            'downloads'         => esc_html_x( 'Downloads', 'edd', 'stream' ),
            'download_category' => esc_html_x( 'Categories', 'edd', 'stream' ),
            'download_tag'      => esc_html_x( 'Tags', 'edd', 'stream' ),
                      Severity: Major
                      Found in connectors/class-connector-edd.php and 1 other location - About 1 hr to fix
                      connectors/class-connector-wordpress-seo.php on lines 77..86

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 116.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                              if ( method_exists( $this, 'check_' . $replacement ) ) {
            $method = "check_{$replacement}";
            $this->{$method}( $old_value, $new_value );
        } else {
            $data         = $this->options[ $option ];
                      Severity: Major
                      Found in connectors/class-connector-edd.php and 1 other location - About 1 hr to fix
                      connectors/class-connector-gravityforms.php on lines 484..499

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 116.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status