Sign upLogin

xwp/stream

View on GitHub
Star
connectors/class-connector-installer.php

Summary

Maintainability
D
2 days
Test Coverage
F
34%

Function callback_upgrader_process_complete has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

    public function callback_upgrader_process_complete( $upgrader, $extra ) {
        $logs    = array();
        $success = ! is_wp_error( $upgrader->skin->result );
        $error   = null;
Severity: Minor
Found in connectors/class-connector-installer.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method callback_upgrader_process_complete has 104 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function callback_upgrader_process_complete( $upgrader, $extra ) {
        $logs    = array();
        $success = ! is_wp_error( $upgrader->skin->result );
        $error   = null;
Severity: Major
Found in connectors/class-connector-installer.php - About 4 hrs to fix

    File class-connector-installer.php has 275 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * Connector for installer
 *
 * @package WP_Stream
    Severity: Minor
    Found in connectors/class-connector-installer.php - About 2 hrs to fix

      Avoid too many return statements within this method.
      Open

              return true;
      Severity: Major
      Found in connectors/class-connector-installer.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return false;
        Severity: Major
        Found in connectors/class-connector-installer.php - About 30 mins to fix

          Function callback_delete_site_transient_update_themes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function callback_delete_site_transient_update_themes() {
        /**
         * This is used as a hack to determine a theme was deleted.
         */
        $backtrace = debug_backtrace(); // @codingStandardsIgnoreLine
          Severity: Minor
          Found in connectors/class-connector-installer.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function callback_deactivate_plugin( $slug, $network_wide ) {
        $_plugins     = $this->get_plugins();
        $name         = $_plugins[ $slug ]['Name'];
        $network_wide = $network_wide ? esc_html__( 'network wide', 'stream' ) : null;
          Severity: Major
          Found in connectors/class-connector-installer.php and 1 other location - About 1 hr to fix
          connectors/class-connector-installer.php on lines 272..289

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 110.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function callback_activate_plugin( $slug, $network_wide ) {
        $_plugins     = $this->get_plugins();
        $name         = $_plugins[ $slug ]['Name'];
        $network_wide = $network_wide ? esc_html__( 'network wide', 'stream' ) : null;
          Severity: Major
          Found in connectors/class-connector-installer.php and 1 other location - About 1 hr to fix
          connectors/class-connector-installer.php on lines 299..316

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 110.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status