File class-connector-jetpack.php
has 528 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* Connector for Jetpack
*
* @package WP_Stream
Method register
has 106 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function register() {
parent::register();
add_filter( 'wp_stream_log_data', array( $this, 'log_override' ) );
Method callback_jetpack_log_entry
has 79 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function callback_jetpack_log_entry( array $entry ) {
if ( isset( $entry['code'] ) ) {
$method = $entry['code'];
} else {
return;
Connector_Jetpack
has 23 functions (exceeds 20 allowed). Consider refactoring. Open
class Connector_Jetpack extends Connector {
/**
* Connector slug
*
* @var string
Function action_links
has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
public function action_links( $links, $record ) {
// @todo provide proper action links
if ( 'jetpack' === $record->connector ) {
if ( 'modules' === $record->context ) {
$slug = $record->get_meta( 'module_slug', true );
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function callback_jetpack_log_entry
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
public function callback_jetpack_log_entry( array $entry ) {
if ( isset( $entry['code'] ) ) {
$method = $entry['code'];
} else {
return;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method action_links
has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function action_links( $links, $record ) {
// @todo provide proper action links
if ( 'jetpack' === $record->connector ) {
if ( 'modules' === $record->context ) {
$slug = $record->get_meta( 'module_slug', true );
Method get_settings_def
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function get_settings_def( $key, $value = null ) {
// Sharing.
if ( 0 === strpos( $key, 'publicize_connections::' ) ) {
global $publicize_ui;
Method log_override
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function log_override( $data ) {
if ( ! is_array( $data ) ) {
return $data;
}
Method check_jetpack_options
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function check_jetpack_options( $old_value, $new_value ) {
$options = array();
if ( ! is_array( $old_value ) || ! is_array( $new_value ) ) {
return;
Function check_jetpack_options
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
public function check_jetpack_options( $old_value, $new_value ) {
$options = array();
if ( ! is_array( $old_value ) || ! is_array( $new_value ) ) {
return;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function log_override
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
public function log_override( $data ) {
if ( ! is_array( $data ) ) {
return $data;
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Similar blocks of code found in 2 locations. Consider refactoring. Open
public function get_action_labels() {
return array(
'activated' => esc_html_x( 'Activated', 'jetpack', 'stream' ),
'deactivated' => esc_html_x( 'Deactivated', 'jetpack', 'stream' ),
'register' => esc_html_x( 'Connected', 'jetpack', 'stream' ),
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 170.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76