Sign upLogin

xwp/stream

View on GitHub
Star
connectors/class-connector-posts.php

Summary

Maintainability
D
2 days
Test Coverage
C
76%

Method callback_transition_post_status has 116 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function callback_transition_post_status( $new, $old, $post ) {
        if ( in_array( $post->post_type, $this->get_excluded_post_types(), true ) ) {
            return;
        }
Severity: Major
Found in connectors/class-connector-posts.php - About 4 hrs to fix

    Function callback_transition_post_status has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

        public function callback_transition_post_status( $new, $old, $post ) {
        if ( in_array( $post->post_type, $this->get_excluded_post_types(), true ) ) {
            return;
        }
    Severity: Minor
    Found in connectors/class-connector-posts.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File class-connector-posts.php has 263 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * Connector for Posts
 *
 * @package WP_Stream
    Severity: Minor
    Found in connectors/class-connector-posts.php - About 2 hrs to fix

      Method action_links has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function action_links( $links, $record ) {
        $post = get_post( $record->object_id );

        if ( $post && $post->post_status === $record->get_meta( 'new_status', true ) ) {
            $post_type_name = $this->get_post_type_name( get_post_type( $post->ID ) );
      Severity: Minor
      Found in connectors/class-connector-posts.php - About 1 hr to fix

        Function action_links has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function action_links( $links, $record ) {
        $post = get_post( $record->object_id );

        if ( $post && $post->post_status === $record->get_meta( 'new_status', true ) ) {
            $post_type_name = $this->get_post_type_name( get_post_type( $post->ID ) );
        Severity: Minor
        Found in connectors/class-connector-posts.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Consider simplifying this complex logical expression.
        Open

                if ( in_array( $new, $start_statuses, true ) ) {
            return;
        } elseif ( defined( 'DOING_AUTOSAVE' ) && DOING_AUTOSAVE ) {
            return;
        } elseif ( 'draft' === $new && 'publish' === $old ) {
        Severity: Major
        Found in connectors/class-connector-posts.php - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      if ( 'trash' === $post->post_status ) {
                $untrash = wp_nonce_url(
                    add_query_arg(
                        array(
                            'action' => 'untrash',
          Severity: Major
          Found in connectors/class-connector-posts.php and 1 other location - About 5 hrs to fix
          connectors/class-connector-wordpress-seo.php on lines 147..187

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 187.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status