Sign upLogin

xwp/stream

View on GitHub
Star
connectors/class-connector-wordpress-seo.php

Summary

Maintainability
F
4 days
Test Coverage
F
1%

File class-connector-wordpress-seo.php has 396 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Connector for WordPress SEO
 *
 * @package WP_Stream
Severity: Minor
Found in connectors/class-connector-wordpress-seo.php - About 5 hrs to fix

    Method settings_labels has 105 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function settings_labels( $option ) {
        $labels = array(
            // wp-content/plugins/wordpress-seo/admin/pages/dashboard.php:.
            'yoast_tracking'                         => esc_html_x( "Allow tracking of this WordPress install's anonymous data.", 'wordpress-seo', 'stream' ), // type = checkbox.
            'disableadvanced_meta'                   => esc_html_x( 'Disable the Advanced part of the WordPress SEO meta box', 'wordpress-seo', 'stream' ), // type = checkbox.
    Severity: Major
    Found in connectors/class-connector-wordpress-seo.php - About 4 hrs to fix

      Method action_links has 58 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function action_links( $links, $record ) {
        // Options.
        $option = $record->get_meta( 'option', true );
        if ( $option ) {
            $key = $record->get_meta( 'option_key', true );
      Severity: Major
      Found in connectors/class-connector-wordpress-seo.php - About 2 hrs to fix

        Function action_links has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
        Open

            public function action_links( $links, $record ) {
        // Options.
        $option = $record->get_meta( 'option', true );
        if ( $option ) {
            $key = $record->get_meta( 'option_key', true );
        Severity: Minor
        Found in connectors/class-connector-wordpress-seo.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method meta has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function meta( $object_id, $meta_key, $meta_value ) {
        $prefix = \WPSEO_Meta::$meta_prefix;

        \WPSEO_Metabox::translate_meta_boxes();
        Severity: Minor
        Found in connectors/class-connector-wordpress-seo.php - About 1 hr to fix

          Function settings_labels has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              private function settings_labels( $option ) {
        $labels = array(
            // wp-content/plugins/wordpress-seo/admin/pages/dashboard.php:.
            'yoast_tracking'                         => esc_html_x( "Allow tracking of this WordPress install's anonymous data.", 'wordpress-seo', 'stream' ), // type = checkbox.
            'disableadvanced_meta'                   => esc_html_x( 'Disable the Advanced part of the WordPress SEO meta box', 'wordpress-seo', 'stream' ), // type = checkbox.
          Severity: Minor
          Found in connectors/class-connector-wordpress-seo.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method callback_wpseo_handle_import has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function callback_wpseo_handle_import() {
        $imports = array(
            'importheadspace'   => esc_html__( 'HeadSpace2', 'stream' ), // type = checkbox.
            'importaioseo'      => esc_html__( 'All-in-One SEO', 'stream' ), // type = checkbox.
            'importaioseoold'   => esc_html__( 'OLD All-in-One SEO', 'stream' ), // type = checkbox.
          Severity: Minor
          Found in connectors/class-connector-wordpress-seo.php - About 1 hr to fix

            Method callback_wpseo_import has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function callback_wpseo_import() {
        $opts = wp_stream_filter_input( INPUT_POST, 'wpseo' );

        if ( wp_stream_filter_input( INPUT_POST, 'wpseo_export' ) ) {
            $this->log(
            Severity: Minor
            Found in connectors/class-connector-wordpress-seo.php - About 1 hr to fix

              Function log_override has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function log_override( $data ) {
        if ( ! is_array( $data ) ) {
            return $data;
        }
              Severity: Minor
              Found in connectors/class-connector-wordpress-seo.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function meta has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function meta( $object_id, $meta_key, $meta_value ) {
        $prefix = \WPSEO_Meta::$meta_prefix;

        \WPSEO_Metabox::translate_meta_boxes();
              Severity: Minor
              Found in connectors/class-connector-wordpress-seo.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                              if ( 'trash' === $post->post_status ) {
                    $untrash = wp_nonce_url(
                        add_query_arg(
                            array(
                                'action' => 'untrash',
              Severity: Major
              Found in connectors/class-connector-wordpress-seo.php and 1 other location - About 5 hrs to fix
              connectors/class-connector-posts.php on lines 87..129

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 187.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      $ast_labels = array(
            'title-'        => esc_html_x( 'Title template', 'wordpress-seo', 'stream' ), // type = textinput.
            'metadesc-'     => esc_html_x( 'Meta description template', 'wordpress-seo', 'stream' ), // type = textarea.
            'metakey-'      => esc_html_x( 'Meta keywords template', 'wordpress-seo', 'stream' ), // type = textinput.
            'noindex-'      => esc_html_x( 'Meta Robots', 'wordpress-seo', 'stream' ), // type = checkbox.
              Severity: Major
              Found in connectors/class-connector-wordpress-seo.php and 1 other location - About 5 hrs to fix
              connectors/class-connector-edd.php on lines 119..130

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 183.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function get_action_labels() {
        return array(
            'created'  => esc_html_x( 'Created', 'wordpress-seo', 'stream' ),
            'updated'  => esc_html_x( 'Updated', 'wordpress-seo', 'stream' ),
            'added'    => esc_html_x( 'Added', 'wordpress-seo', 'stream' ),
              Severity: Major
              Found in connectors/class-connector-wordpress-seo.php and 1 other location - About 1 hr to fix
              connectors/class-connector-edd.php on lines 138..147

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 116.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      $imports = array(
            'importheadspace'   => esc_html__( 'HeadSpace2', 'stream' ), // type = checkbox.
            'importaioseo'      => esc_html__( 'All-in-One SEO', 'stream' ), // type = checkbox.
            'importaioseoold'   => esc_html__( 'OLD All-in-One SEO', 'stream' ), // type = checkbox.
            'importwoo'         => esc_html__( 'WooThemes SEO framework', 'stream' ), // type = checkbox.
              Severity: Major
              Found in connectors/class-connector-wordpress-seo.php and 1 other location - About 1 hr to fix
              connectors/class-connector-gravityforms.php on lines 933..941

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 113.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status