Showing 2 of 2 total issues
Function __init__ has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
Open
def __init__(self, old: Optional[Journey], new: Optional[Journey]):
self.old = old
self.new = new
if old and not new:- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function travel_request_iter has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
Open
def travel_request_iter(self, req: TravelRequest) -> Iterator[Journey]:
"Iteratively fetch a full day."
# TODO: Verify date overlaps and timezones...
cur_dt = req.date.replace(hour=0, minute=0, second=0)
journeys: Set[Journey] = set()- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"