yahoo/mysql_expectations

View on GitHub

Showing 3 of 3 total issues

Method delimited_conjunction has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def delimited_conjunction(conjunction, delimiter, serial_delimiter)
        delimited_conjunction = conjunction
        delimited_conjunction += ' ' unless conjunction.empty?
        if serial_delimiter
          delimited_conjunction = delimiter + delimited_conjunction
Severity: Minor
Found in lib/mysql_expectations/array_refinements.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method to_sentence has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def to_sentence(
        quote_with: "'", delimiter:  ', ', conjunction: 'and',
        serial_delimiter: true
      )
        return '' if self.empty?
Severity: Minor
Found in lib/mysql_expectations/array_refinements.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method failure_message has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def failure_message
        return field_error unless field_match?
        return type_error unless type_match?
        return nullable_error unless nullable_match?
      end
Severity: Minor
Found in lib/mysql_expectations/matchers/table_have_field.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language