Sign upLogin

yammer/yam

View on GitHub
Star

Showing 4 of 4 total issues

Class Base has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Base
      class << self
        include ApiHandler

        # Returns the non-qualified class name
Severity: Minor
Found in lib/yammer/resources/base.rb - About 2 hrs to fix

    Method fetch has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

            def fetch(id)
          return unless identity_map
          attributes = identity_map.get("#{base_name}_#{id}")
          unless attributes
            result = api_handler.send("get_#{base_name}", id)
    Severity: Minor
    Found in lib/yammer/resources/base.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method send_request has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def send_request(method, path, opts={})
    begin
      params  = opts.fetch(:params, {})

      req_opts = self.connection_options.merge({
    Severity: Minor
    Found in lib/yammer/http_adapter.rb - About 1 hr to fix

      Method send_request has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def send_request(method, path, opts={})
    begin
      params  = opts.fetch(:params, {})

      req_opts = self.connection_options.merge({
      Severity: Minor
      Found in lib/yammer/http_adapter.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language