Sign upLogin

yannickcr/eslint-plugin-react

View on GitHub
Star

Showing 710 of 710 total issues

Function verifyDefaultPropsDestructuring has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function verifyDefaultPropsDestructuring(context, properties) {
  // Loop through each of the default params
  properties.filter((prop) => prop.type === 'Property' && prop.value.type === 'AssignmentPattern').forEach((prop) => {
    const propName = prop.key.name;
    const propDefaultValue = prop.value;
Severity: Minor
Found in lib/rules/no-object-type-as-default-prop.js - About 1 hr to fix

    Function validateBeforeSelfClosing has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function validateBeforeSelfClosing(context, node, option) {
  const sourceCode = getSourceCode(context);
  const leftToken = getTokenBeforeClosingBracket(node);
  const closingSlash = sourceCode.getTokenAfter(leftToken);
    Severity: Minor
    Found in lib/rules/jsx-tag-spacing.js - About 1 hr to fix

      Function checkPropsOrder has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function checkPropsOrder(properties) {
      const propertiesInfos = properties.map((node) => ({
        name: getPropertyName(node),
        getter: node.kind === 'get',
        setter: node.kind === 'set',
      Severity: Minor
      Found in lib/rules/sort-comp.js - About 1 hr to fix

        Function create has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          create: Components.detect((context, components, utils) => {
    /**
     * Checks if the component is valid
     * @param {Object} component The component to process
     * @returns {boolean} True if the component is valid, false if not.
        Severity: Minor
        Found in lib/rules/no-set-state.js - About 1 hr to fix

          Function ObjectTypeAnnotation has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              ObjectTypeAnnotation(annotation, parentName, seen) {
      let containsUnresolvedObjectTypeSpread = false;
      let containsSpread = false;
      const containsIndexers = !!annotation.indexers && annotation.indexers.length > 0;
      const shapeTypeDefinition = {
          Severity: Minor
          Found in lib/util/propTypes.js - About 1 hr to fix

            Function JSXSpreadAttribute has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  JSXSpreadAttribute(node) {
        const jsxOpeningElement = node.parent.name;
        const type = jsxOpeningElement.type;

        let tagName;
            Severity: Minor
            Found in lib/rules/jsx-props-no-spreading.js - About 1 hr to fix

              Function checkProperties has 36 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  function checkProperties(declarations) {
      if (declarations) {
        declarations.forEach((declaration) => {
          if (declaration.type !== 'Property') {
            return;
              Severity: Minor
              Found in lib/rules/forbid-prop-types.js - About 1 hr to fix

                Function create has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  create(context) {
    const sourceCode = context.getSourceCode();

    return {
      'FunctionExpression, ArrowFunctionExpression'(node) {
                Severity: Minor
                Found in lib/rules/forward-ref-uses-ref.js - About 1 hr to fix

                  Function isCreateContext has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                  Open

                  module.exports = function isCreateContext(node) {
  if (
    node.init
    && node.init.callee
  ) {
                  Severity: Minor
                  Found in lib/util/isCreateContext.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function create has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                  Open

                    create: Components.detect((context, components) => {
    const configuration = context.options[0] || {};
    const forbidDefaultForRequired = configuration.forbidDefaultForRequired || false;
    const classes = configuration.classes || 'defaultProps';
    /**
                  Severity: Minor
                  Found in lib/rules/require-default-props.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function create has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                  Open

                    create(context) {
    return {
      JSXAttribute(node) {
        const attributes = new Set(context.options[0] || DEFAULT_ATTRIBUTES);
                  Severity: Minor
                  Found in lib/rules/no-invalid-html-attribute.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function create has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                  Open

                    create(context) {
    const sourceCode = context.getSourceCode();

    return {
      'FunctionExpression, ArrowFunctionExpression'(node) {
                  Severity: Minor
                  Found in lib/rules/forward-ref-uses-ref.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function create has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                  Open

                    create(context) {
    return {
      JSXOpeningElement(node) {
        let name;
        if (node.name.namespace) {
                  Severity: Minor
                  Found in lib/rules/jsx-uses-vars.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function isComponentInRenderProp has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function isComponentInRenderProp(node, context, propNamePattern) {
  if (
    node
    && node.parent
    && node.parent.type === 'Property'
                  Severity: Minor
                  Found in lib/rules/no-unstable-nested-components.js - About 1 hr to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                if (!spacedAfter) {
              report(context, messages.needSpaceAfter, 'needSpaceAfter', {
                node: attrNode,
                loc: equalToken.loc.start,
                fix(fixer) {
                    Severity: Major
                    Found in lib/rules/jsx-equals-spacing.js and 1 other location - About 1 hr to fix
                    lib/rules/jsx-equals-spacing.js on lines 89..97

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 63.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                if (!spacedBefore) {
              report(context, messages.needSpaceBefore, 'needSpaceBefore', {
                node: attrNode,
                loc: equalToken.loc.start,
                fix(fixer) {
                    Severity: Major
                    Found in lib/rules/jsx-equals-spacing.js and 1 other location - About 1 hr to fix
                    lib/rules/jsx-equals-spacing.js on lines 98..106

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 63.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function Program:exit has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                          'Program:exit'() {
        if (!rule) {
          return;
        }
                    Severity: Minor
                    Found in lib/rules/boolean-prop-naming.js - About 1 hr to fix

                      Function getJSXElementName has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          function getJSXElementName(node) {
      if (node.openingElement.name.type === 'JSXIdentifier') {
        const name = node.openingElement.name.name;
        return {
          name: renamedImportMap.get(name) || name,
                      Severity: Minor
                      Found in lib/rules/jsx-no-literals.js - About 1 hr to fix

                        Function create has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          create(context) {
    /**
     * Checks for shouldComponentUpdate property
     * @param {ASTNode} node The AST node being checked.
     * @returns {boolean} Whether or not the property exists.
                        Severity: Minor
                        Found in lib/rules/no-redundant-should-component-update.js - About 1 hr to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  node.parent
        && node.parent.parent
        && node.parent.parent.type === 'LogicalExpression'
        && node.parent.parent.right === node.parent
        && !indentLogicalExpressions
                          Severity: Major
                          Found in lib/rules/jsx-indent.js and 1 other location - About 1 hr to fix
                          lib/rules/jsx-indent.js on lines 220..224

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 62.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Severity
                          Category
                          Status
                          Source
                          Language