yannickcr/eslint-plugin-react

View on GitHub
lib/rules/jsx-sort-props.js

Summary

Maintainability
F
5 days
Test Coverage

File jsx-sort-props.js has 413 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * @fileoverview Enforce props alphabetical sorting
 * @author Ilya Volodin, Yannick Croissant
 */

Severity: Minor
Found in lib/rules/jsx-sort-props.js - About 5 hrs to fix

    Function getGroupsOfSortableAttributes has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
    Open

    function getGroupsOfSortableAttributes(attributes, context) {
      const sourceCode = context.getSourceCode();
    
      const sortableAttributeGroups = [];
      let groupCount = 0;
    Severity: Minor
    Found in lib/rules/jsx-sort-props.js - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function contextCompare has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
    Open

    function contextCompare(a, b, options) {
      let aProp = propName(a);
      let bProp = propName(b);
    
      const aSortToEnd = shouldSortToEnd(a);
    Severity: Minor
    Found in lib/rules/jsx-sort-props.js - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function create has 107 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      create(context) {
        const configuration = context.options[0] || {};
        const ignoreCase = configuration.ignoreCase || false;
        const callbacksLast = configuration.callbacksLast || false;
        const shorthandFirst = configuration.shorthandFirst || false;
    Severity: Major
    Found in lib/rules/jsx-sort-props.js - About 4 hrs to fix

      Function JSXOpeningElement has 89 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            JSXOpeningElement(node) {
              // `dangerouslySetInnerHTML` is only "reserved" on DOM components
              const nodeReservedList = reservedFirst && !jsxUtil.isDOMComponent(node) ? reservedList.filter((prop) => prop !== 'dangerouslySetInnerHTML') : reservedList;
      
              node.attributes.reduce((memo, decl, idx, attrs) => {
      Severity: Major
      Found in lib/rules/jsx-sort-props.js - About 3 hrs to fix

        Function contextCompare has 66 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function contextCompare(a, b, options) {
          let aProp = propName(a);
          let bProp = propName(b);
        
          const aSortToEnd = shouldSortToEnd(a);
        Severity: Major
        Found in lib/rules/jsx-sort-props.js - About 2 hrs to fix

          Function getGroupsOfSortableAttributes has 61 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function getGroupsOfSortableAttributes(attributes, context) {
            const sourceCode = context.getSourceCode();
          
            const sortableAttributeGroups = [];
            let groupCount = 0;
          Severity: Major
          Found in lib/rules/jsx-sort-props.js - About 2 hrs to fix

            Function generateFixerFunction has 49 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function generateFixerFunction(node, context, reservedList) {
              const sourceCode = context.getSourceCode();
              const attributes = node.attributes.slice(0);
              const configuration = context.options[0] || {};
              const ignoreCase = configuration.ignoreCase || false;
            Severity: Minor
            Found in lib/rules/jsx-sort-props.js - About 1 hr to fix

              Function validateReservedFirstConfig has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

              function validateReservedFirstConfig(context, reservedFirst) {
                if (reservedFirst) {
                  if (Array.isArray(reservedFirst)) {
                    // Only allow a subset of reserved words in customized lists
                    const nonReservedWords = reservedFirst.filter((word) => !isReservedPropName(
              Severity: Minor
              Found in lib/rules/jsx-sort-props.js - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid deeply nested control flow statements.
              Open

                        if (attributeline + 1 === commentline && nextAttribute) {
                          attributeMap.set(attribute, { end: nextAttribute.range[1], hasComment: true });
                          addtoSortableAttributeGroups(attribute);
                          i += 1;
                        } else if (attributeline === commentline) {
              Severity: Major
              Found in lib/rules/jsx-sort-props.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                        } else if (comment.length > 1 && attributeline + 1 === comment[1].loc.start.line && nextAttribute) {
                          const commentNextAttribute = sourceCode.getCommentsAfter(nextAttribute);
                          attributeMap.set(attribute, { end: nextAttribute.range[1], hasComment: true });
                          if (
                            commentNextAttribute.length === 1
                Severity: Major
                Found in lib/rules/jsx-sort-props.js - About 45 mins to fix

                  Function reportNodeAttribute has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  function reportNodeAttribute(nodeAttribute, errorType, node, context, reservedList) {
                  Severity: Minor
                  Found in lib/rules/jsx-sort-props.js - About 35 mins to fix

                    Avoid too many return statements within this function.
                    Open

                        return aProp.localeCompare(bProp, actualLocale);
                    Severity: Major
                    Found in lib/rules/jsx-sort-props.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                          return aProp < bProp ? -1 : 1;
                      Severity: Major
                      Found in lib/rules/jsx-sort-props.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                            return 0;
                        Severity: Major
                        Found in lib/rules/jsx-sort-props.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                        return memo;
                          Severity: Major
                          Found in lib/rules/jsx-sort-props.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                  return multilineSign;
                            Severity: Major
                            Found in lib/rules/jsx-sort-props.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                            return memo;
                              Severity: Major
                              Found in lib/rules/jsx-sort-props.js - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                      return -1;
                                Severity: Major
                                Found in lib/rules/jsx-sort-props.js - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                        return -multilineSign;
                                  Severity: Major
                                  Found in lib/rules/jsx-sort-props.js - About 30 mins to fix

                                    Avoid too many return statements within this function.
                                    Open

                                          return 1;
                                    Severity: Major
                                    Found in lib/rules/jsx-sort-props.js - About 30 mins to fix

                                      Avoid too many return statements within this function.
                                      Open

                                                    return decl;
                                      Severity: Major
                                      Found in lib/rules/jsx-sort-props.js - About 30 mins to fix

                                        Avoid too many return statements within this function.
                                        Open

                                                      return decl;
                                        Severity: Major
                                        Found in lib/rules/jsx-sort-props.js - About 30 mins to fix

                                          Avoid too many return statements within this function.
                                          Open

                                                        return decl;
                                          Severity: Major
                                          Found in lib/rules/jsx-sort-props.js - About 30 mins to fix

                                            Avoid too many return statements within this function.
                                            Open

                                                          return decl;
                                            Severity: Major
                                            Found in lib/rules/jsx-sort-props.js - About 30 mins to fix

                                              Avoid too many return statements within this function.
                                              Open

                                                          return memo;
                                              Severity: Major
                                              Found in lib/rules/jsx-sort-props.js - About 30 mins to fix

                                                Avoid too many return statements within this function.
                                                Open

                                                          return decl;
                                                Severity: Major
                                                Found in lib/rules/jsx-sort-props.js - About 30 mins to fix

                                                  Avoid too many return statements within this function.
                                                  Open

                                                                return decl;
                                                  Severity: Major
                                                  Found in lib/rules/jsx-sort-props.js - About 30 mins to fix

                                                    Avoid too many return statements within this function.
                                                    Open

                                                          return shorthandSign;
                                                    Severity: Major
                                                    Found in lib/rules/jsx-sort-props.js - About 30 mins to fix

                                                      Avoid too many return statements within this function.
                                                      Open

                                                          return 0;
                                                      Severity: Major
                                                      Found in lib/rules/jsx-sort-props.js - About 30 mins to fix

                                                        Avoid too many return statements within this function.
                                                        Open

                                                          return aProp.localeCompare(bProp, actualLocale);
                                                        Severity: Major
                                                        Found in lib/rules/jsx-sort-props.js - About 30 mins to fix

                                                          Avoid too many return statements within this function.
                                                          Open

                                                                        return memo;
                                                          Severity: Major
                                                          Found in lib/rules/jsx-sort-props.js - About 30 mins to fix

                                                            Avoid too many return statements within this function.
                                                            Open

                                                                          return memo;
                                                            Severity: Major
                                                            Found in lib/rules/jsx-sort-props.js - About 30 mins to fix

                                                              Avoid too many return statements within this function.
                                                              Open

                                                                    return -shorthandSign;
                                                              Severity: Major
                                                              Found in lib/rules/jsx-sort-props.js - About 30 mins to fix

                                                                Avoid too many return statements within this function.
                                                                Open

                                                                              return memo;
                                                                Severity: Major
                                                                Found in lib/rules/jsx-sort-props.js - About 30 mins to fix

                                                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                                                  Open

                                                                            } else if (multiline === 'last') {
                                                                              if (!previousIsMultiline && currentIsMultiline) {
                                                                                // Entering the multiline prop section
                                                                                return decl;
                                                                              }
                                                                  Severity: Minor
                                                                  Found in lib/rules/jsx-sort-props.js and 1 other location - About 50 mins to fix
                                                                  lib/rules/jsx-sort-props.js on lines 452..463

                                                                  Duplicated Code

                                                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                                  Tuning

                                                                  This issue has a mass of 51.

                                                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                                  Refactorings

                                                                  Further Reading

                                                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                                                  Open

                                                                            if (callbacksLast) {
                                                                              if (!previousIsCallback && currentIsCallback) {
                                                                                // Entering the callback prop section
                                                                                return decl;
                                                                              }
                                                                  Severity: Minor
                                                                  Found in lib/rules/jsx-sort-props.js and 1 other location - About 50 mins to fix
                                                                  lib/rules/jsx-sort-props.js on lines 500..511

                                                                  Duplicated Code

                                                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                                  Tuning

                                                                  This issue has a mass of 51.

                                                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                                  Refactorings

                                                                  Further Reading

                                                                  There are no issues that match your filters.

                                                                  Category
                                                                  Status