File jsx-sort-props.js
has 413 lines of code (exceeds 250 allowed). Consider refactoring. Open
/**
* @fileoverview Enforce props alphabetical sorting
* @author Ilya Volodin, Yannick Croissant
*/
Function getGroupsOfSortableAttributes
has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring. Open
function getGroupsOfSortableAttributes(attributes, context) {
const sourceCode = context.getSourceCode();
const sortableAttributeGroups = [];
let groupCount = 0;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function contextCompare
has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring. Open
function contextCompare(a, b, options) {
let aProp = propName(a);
let bProp = propName(b);
const aSortToEnd = shouldSortToEnd(a);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function create
has 107 lines of code (exceeds 25 allowed). Consider refactoring. Open
create(context) {
const configuration = context.options[0] || {};
const ignoreCase = configuration.ignoreCase || false;
const callbacksLast = configuration.callbacksLast || false;
const shorthandFirst = configuration.shorthandFirst || false;
Function JSXOpeningElement
has 89 lines of code (exceeds 25 allowed). Consider refactoring. Open
JSXOpeningElement(node) {
// `dangerouslySetInnerHTML` is only "reserved" on DOM components
const nodeReservedList = reservedFirst && !jsxUtil.isDOMComponent(node) ? reservedList.filter((prop) => prop !== 'dangerouslySetInnerHTML') : reservedList;
node.attributes.reduce((memo, decl, idx, attrs) => {
Function contextCompare
has 66 lines of code (exceeds 25 allowed). Consider refactoring. Open
function contextCompare(a, b, options) {
let aProp = propName(a);
let bProp = propName(b);
const aSortToEnd = shouldSortToEnd(a);
Function getGroupsOfSortableAttributes
has 61 lines of code (exceeds 25 allowed). Consider refactoring. Open
function getGroupsOfSortableAttributes(attributes, context) {
const sourceCode = context.getSourceCode();
const sortableAttributeGroups = [];
let groupCount = 0;
Function generateFixerFunction
has 49 lines of code (exceeds 25 allowed). Consider refactoring. Open
function generateFixerFunction(node, context, reservedList) {
const sourceCode = context.getSourceCode();
const attributes = node.attributes.slice(0);
const configuration = context.options[0] || {};
const ignoreCase = configuration.ignoreCase || false;
Function validateReservedFirstConfig
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
function validateReservedFirstConfig(context, reservedFirst) {
if (reservedFirst) {
if (Array.isArray(reservedFirst)) {
// Only allow a subset of reserved words in customized lists
const nonReservedWords = reservedFirst.filter((word) => !isReservedPropName(
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid deeply nested control flow statements. Open
if (attributeline + 1 === commentline && nextAttribute) {
attributeMap.set(attribute, { end: nextAttribute.range[1], hasComment: true });
addtoSortableAttributeGroups(attribute);
i += 1;
} else if (attributeline === commentline) {
Avoid deeply nested control flow statements. Open
} else if (comment.length > 1 && attributeline + 1 === comment[1].loc.start.line && nextAttribute) {
const commentNextAttribute = sourceCode.getCommentsAfter(nextAttribute);
attributeMap.set(attribute, { end: nextAttribute.range[1], hasComment: true });
if (
commentNextAttribute.length === 1
Function reportNodeAttribute
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
function reportNodeAttribute(nodeAttribute, errorType, node, context, reservedList) {
Avoid too many return
statements within this function. Open
return aProp.localeCompare(bProp, actualLocale);
Avoid too many return
statements within this function. Open
return aProp < bProp ? -1 : 1;
Avoid too many return
statements within this function. Open
return 0;
Avoid too many return
statements within this function. Open
return memo;
Avoid too many return
statements within this function. Open
return multilineSign;
Avoid too many return
statements within this function. Open
return memo;
Avoid too many return
statements within this function. Open
return -1;
Avoid too many return
statements within this function. Open
return -multilineSign;
Avoid too many return
statements within this function. Open
return 1;
Avoid too many return
statements within this function. Open
return decl;
Avoid too many return
statements within this function. Open
return decl;
Avoid too many return
statements within this function. Open
return decl;
Avoid too many return
statements within this function. Open
return decl;
Avoid too many return
statements within this function. Open
return memo;
Avoid too many return
statements within this function. Open
return decl;
Avoid too many return
statements within this function. Open
return decl;
Avoid too many return
statements within this function. Open
return shorthandSign;
Avoid too many return
statements within this function. Open
return 0;
Avoid too many return
statements within this function. Open
return aProp.localeCompare(bProp, actualLocale);
Avoid too many return
statements within this function. Open
return memo;
Avoid too many return
statements within this function. Open
return memo;
Avoid too many return
statements within this function. Open
return -shorthandSign;
Avoid too many return
statements within this function. Open
return memo;
Similar blocks of code found in 2 locations. Consider refactoring. Open
} else if (multiline === 'last') {
if (!previousIsMultiline && currentIsMultiline) {
// Entering the multiline prop section
return decl;
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 51.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
if (callbacksLast) {
if (!previousIsCallback && currentIsCallback) {
// Entering the callback prop section
return decl;
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 51.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76