Sign upLogin

yariplus/nodebb-plugin-newsletter

View on GitHub
Star

Showing 16 of 16 total issues

Function load has 106 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.load = async data => {
  log.info('Initializing Newsletter...')

  const {app, router, middleware} = data
Severity: Major
Found in lib/index.js - About 4 hrs to fix

    Function init has 73 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      Newsletter.init = () => {
    let $everyone = $('#checkbox-everyone')
    let $custom = $('#custom-groups')
    let $blocklistGlobalText = $('#email-global-blocklist')
    let $blocklistCheck = $('#use-blocklist')
    Severity: Major
    Found in public/js/acp.js - About 2 hrs to fix

      Function openNewsletterModal has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          async function openNewsletterModal() {
      const $composer = $('.composer[data-uuid="' + data.post_uuid + '"]')
      const groups = await socket.emit('admin.Newsletter.getGroups')

      let title = $composer.find('.title').val() || 'Newsletter Subject'
      Severity: Major
      Found in public/js/topic.js - About 2 hrs to fix

        Function send has 61 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          SocketAdmin.Newsletter.send = async (socket, data) => {
    let { subject, body, groups, override, blocklist, prefixTitle } = data
    let count = 0
    let sets
        Severity: Major
        Found in lib/index.js - About 2 hrs to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  function getSelectedGroups () {
          let groups = []

          $('.nl-group').each((i, el) => {
            if (el.checked) {
          Severity: Major
          Found in public/js/topic.js and 1 other location - About 2 hrs to fix
          public/js/acp.js on lines 42..52

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 75.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              function getSelectedGroups () {
      let groups = []

      $('.nl-group').each((i, el) => {
        if (el.checked) {
          Severity: Major
          Found in public/js/acp.js and 1 other location - About 2 hrs to fix
          public/js/topic.js on lines 109..119

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 75.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function load has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

          exports.load = async data => {
  log.info('Initializing Newsletter...')

  const {app, router, middleware} = data
          Severity: Minor
          Found in lib/index.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  let blocklist = $blocklistCheck[0].checked ? $blocklist.val().split(/[\n, ]+/).filter(e => e).map(e => e.trim()) : []
          Severity: Major
          Found in public/js/acp.js and 1 other location - About 1 hr to fix
          public/js/topic.js on lines 63..63

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 68.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          let blacklist = $blacklistCheck[0].checked ? $blacklist.val().split(/[\n, ]+/).filter(e => e).map(e => e.trim()) : []
          Severity: Major
          Found in public/js/topic.js and 1 other location - About 1 hr to fix
          public/js/acp.js on lines 74..74

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 68.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              function displayBlocklist () {
      if ($blocklistCheck[0].checked) {
        $blocklistDiv.fadeIn()
      } else {
        $blocklistDiv.fadeOut()
          Severity: Major
          Found in public/js/acp.js and 3 other locations - About 50 mins to fix
          public/js/acp.js on lines 24..30
          public/js/topic.js on lines 91..97
          public/js/topic.js on lines 100..106

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  function displayCustomGroups () {
          if ($everyone[0].checked) {
            $custom.fadeOut()
          } else {
            $custom.fadeIn()
          Severity: Major
          Found in public/js/topic.js and 3 other locations - About 50 mins to fix
          public/js/acp.js on lines 24..30
          public/js/acp.js on lines 33..39
          public/js/topic.js on lines 100..106

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              function displayCustomGroups () {
      if ($everyone[0].checked) {
        $custom.fadeOut()
      } else {
        $custom.fadeIn()
          Severity: Major
          Found in public/js/acp.js and 3 other locations - About 50 mins to fix
          public/js/acp.js on lines 33..39
          public/js/topic.js on lines 91..97
          public/js/topic.js on lines 100..106

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  function displayBlacklist () {
          if ($blacklistCheck[0].checked) {
            $blacklistForm.fadeIn()
          } else {
            $blacklistForm.fadeOut()
          Severity: Major
          Found in public/js/topic.js and 3 other locations - About 50 mins to fix
          public/js/acp.js on lines 24..30
          public/js/acp.js on lines 33..39
          public/js/topic.js on lines 91..97

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid too many return statements within this function.
          Open

                  return true
          Severity: Major
          Found in lib/index.js - About 30 mins to fix

            TODO found
            Open

                // TODO: Fix this to actually work properly.
            Severity: Minor
            Found in lib/index.js by fixme

            TODO found
            Open

                            // TODO: return info
            Severity: Minor
            Found in public/js/topic.js by fixme
            Severity
            Category
            Status
            Source
            Language