Sign upLogin

yariplus/nodebb-plugin-newsletter

View on GitHub
Star

Showing 6 of 16 total issues

Function load has 106 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.load = async data => {
  log.info('Initializing Newsletter...')

  const {app, router, middleware} = data
Severity: Major
Found in lib/index.js - About 4 hrs to fix

    Function init has 73 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      Newsletter.init = () => {
    let $everyone = $('#checkbox-everyone')
    let $custom = $('#custom-groups')
    let $blocklistGlobalText = $('#email-global-blocklist')
    let $blocklistCheck = $('#use-blocklist')
    Severity: Major
    Found in public/js/acp.js - About 2 hrs to fix

      Function openNewsletterModal has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          async function openNewsletterModal() {
      const $composer = $('.composer[data-uuid="' + data.post_uuid + '"]')
      const groups = await socket.emit('admin.Newsletter.getGroups')

      let title = $composer.find('.title').val() || 'Newsletter Subject'
      Severity: Major
      Found in public/js/topic.js - About 2 hrs to fix

        Function send has 61 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          SocketAdmin.Newsletter.send = async (socket, data) => {
    let { subject, body, groups, override, blocklist, prefixTitle } = data
    let count = 0
    let sets
        Severity: Major
        Found in lib/index.js - About 2 hrs to fix

          Function load has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

          exports.load = async data => {
  log.info('Initializing Newsletter...')

  const {app, router, middleware} = data
          Severity: Minor
          Found in lib/index.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

                  return true
          Severity: Major
          Found in lib/index.js - About 30 mins to fix
            Severity
            Category
            Status
            Source
            Language