Sign upLogin

yariplus/nodebb-plugin-newsletter

View on GitHub
Star
lib/index.js

Summary

Maintainability
C
1 day
Test Coverage

Function load has 106 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.load = async data => {
  log.info('Initializing Newsletter...')

  const {app, router, middleware} = data
Severity: Major
Found in lib/index.js - About 4 hrs to fix

    Function send has 61 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      SocketAdmin.Newsletter.send = async (socket, data) => {
    let { subject, body, groups, override, blocklist, prefixTitle } = data
    let count = 0
    let sets
    Severity: Major
    Found in lib/index.js - About 2 hrs to fix

      Function load has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

      exports.load = async data => {
  log.info('Initializing Newsletter...')

  const {app, router, middleware} = data
      Severity: Minor
      Found in lib/index.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

              return true
      Severity: Major
      Found in lib/index.js - About 30 mins to fix

        TODO found
        Open

            // TODO: Fix this to actually work properly.
        Severity: Minor
        Found in lib/index.js by fixme

        There are no issues that match your filters.

        Category
        Status