Sign upLogin

yashketkar/video-player

View on GitHub
Star

Showing 144 of 144 total issues

Identical blocks of code found in 3 locations. Consider refactoring.
Open

            case R.id.nav_videos:
                fragment = VideosFragment.newInstance();
                switchFragment(fragment);
                mTitle = getString(R.string.nav_local_videos);
                restoreActionBar();
Severity: Minor
Found in app/src/main/java/com/yashketkar/ykplayer/MainActivity.java and 2 other locations - About 35 mins to fix
app/src/main/java/com/yashketkar/ykplayer/MainActivity.java on lines 200..205
app/src/main/java/com/yashketkar/ykplayer/MainActivity.java on lines 206..211

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    @Override
    public void onAttach(Context context) {
        super.onAttach(context);
        if (context instanceof OnFragmentInteractionListener) {
            mListener = (OnFragmentInteractionListener) context;
Severity: Minor
Found in app/src/main/java/com/yashketkar/ykplayer/ZbigzFragment.java and 2 other locations - About 35 mins to fix
app/src/main/java/com/yashketkar/ykplayer/LiveTVFragment.java on lines 175..184
app/src/main/java/com/yashketkar/ykplayer/VideosFragment.java on lines 80..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this method.
Open

          return;
Severity: Major
Found in vitamio/src/io/vov/vitamio/MediaPlayer.java - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

              return;
    Severity: Major
    Found in vitamio/src/io/vov/vitamio/MediaPlayer.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                return;
      Severity: Major
      Found in vitamio/src/io/vov/vitamio/MediaPlayer.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return;
        Severity: Major
        Found in vitamio/src/io/vov/vitamio/MediaPlayer.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                                  return false;
          Severity: Major
          Found in vitamio/src/io/vov/vitamio/utils/Base64.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return false;
            Severity: Major
            Found in vitamio/src/io/vov/vitamio/utils/Base64.java - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public static void closeSilently(ParcelFileDescriptor c) {
        if (c == null)
            return;
        try {
            c.close();
              Severity: Minor
              Found in vitamio/src/io/vov/vitamio/utils/IOUtils.java and 1 other location - About 30 mins to fix
              vitamio/src/io/vov/vitamio/utils/IOUtils.java on lines 28..36

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 40.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Avoid too many return statements within this method.
              Open

                        return;
              Severity: Major
              Found in vitamio/src/io/vov/vitamio/MediaPlayer.java - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                        return false;
                Severity: Major
                Found in vitamio/src/io/vov/vitamio/utils/Base64.java - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return true;
                  Severity: Major
                  Found in vitamio/src/io/vov/vitamio/utils/Base64.java - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        public static void closeSilently(Closeable c) {
        if (c == null)
            return;
        try {
            c.close();
                    Severity: Minor
                    Found in vitamio/src/io/vov/vitamio/utils/IOUtils.java and 1 other location - About 30 mins to fix
                    vitamio/src/io/vov/vitamio/utils/IOUtils.java on lines 38..46

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 40.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Avoid too many return statements within this method.
                    Open

                                return true;
                    Severity: Major
                    Found in vitamio/src/io/vov/vitamio/utils/Base64.java - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                return;
                      Severity: Major
                      Found in vitamio/src/io/vov/vitamio/MediaPlayer.java - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                                return false;
                        Severity: Major
                        Found in vitamio/src/io/vov/vitamio/utils/Base64.java - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                          return false;
                          Severity: Major
                          Found in vitamio/src/io/vov/vitamio/utils/Base64.java - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                      return;
                            Severity: Major
                            Found in vitamio/src/io/vov/vitamio/MediaPlayer.java - About 30 mins to fix

                              Method requestPermissions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  private void requestPermissions(final Activity thisActivity, View videosFragmentView) {
        if (ContextCompat.checkSelfPermission(thisActivity,
                Manifest.permission.READ_EXTERNAL_STORAGE)
                != PackageManager.PERMISSION_GRANTED) {
            // Should we show an explanation?
                              Severity: Minor
                              Found in app/src/main/java/com/yashketkar/ykplayer/VideosFragment.java - About 25 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Method getUniqueFileName has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  public static String getUniqueFileName(String name, String id) {
        StringBuilder sb = new StringBuilder();
        for (Character c : name.toCharArray()) {
            if (FILE_NAME_RESERVED.indexOf(c) == -1) {
                sb.append(c);
                              Severity: Minor
                              Found in vitamio/src/io/vov/vitamio/utils/FileUtils.java - About 25 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Severity
                              Category
                              Status
                              Source
                              Language