Sign upLogin

yasshi2525/RushHour

View on GitHub
Star

Showing 224 of 224 total issues

Function processMsg has a Cognitive Complexity of 81 (exceeds 20 allowed). Consider refactoring.
Open

func processMsg(msg *Operation) time.Time {
    MuModel.Lock()
    defer MuModel.Unlock()
    lock := time.Now()
Severity: Minor
Found in services/model.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (this.renderer.width < this.renderer.height) {
      // 縦長
      if (x - shortRadius < config.gamePos.min.x) {
        x = config.gamePos.min.x + shortRadius;
      }
Severity: Major
Found in client/src/models/index.ts and 1 other location - About 1 day to fix
client/src/models/index.ts on lines 143..160

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 239.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    } else {
      // 横長
      if (x - longRadius < config.gamePos.min.x) {
        x = config.gamePos.min.x + longRadius;
      }
Severity: Major
Found in client/src/models/index.ts and 1 other location - About 1 day to fix
client/src/models/index.ts on lines 126..143

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 239.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function default has 217 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function(props: Attributes) {
  const [opened, setOpened] = React.useState(false);
  const theme = useTheme();
  const classes = useStyles(theme);
  const isFullScreen = useMediaQuery(theme.breakpoints.down("sm"));
Severity: Major
Found in client/src/components/Register.tsx - About 1 day to fix

    Function default has 183 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export default function() {
  const theme = useTheme();
  const classes = useStyles(theme);
  const [opened, setOpened] = React.useState(false);
  const [confirmMessage, setConfirmMessage] = React.useState("");
    Severity: Major
    Found in client/src/components/Administrator.tsx - About 7 hrs to fix

      Function default has 168 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export default function() {
  const [opened, setOpened] = React.useState(false);
  const theme = useTheme();
  const classes = useStyles(theme);
  const isFullScreen = useMediaQuery(theme.breakpoints.down("sm"));
      Severity: Major
      Found in client/src/components/UserSettings.tsx - About 6 hrs to fix

        Function useCursor has 152 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export const useCursor = () => {
  const model = useContext(ModelContext);
  const [count, setCount] = useState(0);
  const [client, setClient] = useState<Point>();
  const [pressed, setPressed] = useState(false);
        Severity: Major
        Found in client/src/common/cursor.ts - About 6 hrs to fix

          Function processMsg has 143 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func processMsg(msg *Operation) time.Time {
    MuModel.Lock()
    defer MuModel.Unlock()
    lock := time.Now()
          Severity: Major
          Found in services/model.go - About 4 hrs to fix

            Function CacheMap has 116 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            const CacheMap = () => {
  const theme = useTheme();
  const classes = useStyles(theme);
  const [{ min_scale, max_scale }] = useContext(ConfigContext);
  const [coordX, coordY, coordS, , , update] = useContext(CoordContext);
            Severity: Major
            Found in client/src/components/CacheMap.tsx - About 4 hrs to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                const onTouchStart = useCallback(
    (e: React.TouchEvent) => {
      if (pressed) {
        console.info("touchstart in pressed state usePinch");
      } else if (e.targetTouches.length === 1) {
              Severity: Major
              Found in client/src/common/zoom.ts and 1 other location - About 4 hrs to fix
              client/src/common/scroll.ts on lines 119..134

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 127.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                const onTouchStart = useCallback(
    (e: React.TouchEvent) => {
      if (pressed) {
        console.info("touchstart in pressed state useSwipe");
      } else if (e.targetTouches.length > 1) {
              Severity: Major
              Found in client/src/common/scroll.ts and 1 other location - About 4 hrs to fix
              client/src/common/zoom.ts on lines 104..119

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 127.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function useRail has 107 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              export const useRail = () => {
  const model = useContext(ModelContext);
  const [, reloadPlayers] = useContext(PlayerContext);

  const resolve = useCallback((err: ResolveError) => {
              Severity: Major
              Found in client/src/common/rail.ts - About 4 hrs to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                export class YBorderContainer extends NormalBorderContainer
  implements MonitorContainer {
  constructor(props: BorderProperty) {
    super({ ...props, v: true });
  }
                Severity: Major
                Found in client/src/models/border.ts and 1 other location - About 4 hrs to fix
                client/src/models/border.ts on lines 326..339

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 120.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                export class XBorderContainer extends NormalBorderContainer
  implements MonitorContainer {
  constructor(props: BorderProperty) {
    super({ ...props, v: false });
  }
                Severity: Major
                Found in client/src/models/border.ts and 1 other location - About 4 hrs to fix
                client/src/models/border.ts on lines 341..354

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 120.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                export const useHttpGetTask = <
  I extends FlatObject,
  O extends SerializableObject
>(
  endpoint: GetEndpoint<I, O> | GetAuthEndpoint<I, O>,
                Severity: Major
                Found in client/src/common/utils/http_get.ts and 1 other location - About 4 hrs to fix
                client/src/common/utils/http_http.ts on lines 90..101

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 115.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                export const useHttpHttpTask = <
  I extends SerializableObject,
  O extends SerializableObject
>(
  ep: HttpEndpoint<I, O> | HttpAuthEndpoint<I, O>,
                Severity: Major
                Found in client/src/common/utils/http_http.ts and 1 other location - About 4 hrs to fix
                client/src/common/utils/http_get.ts on lines 84..95

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 115.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function useFlash has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
                Open

                const useFlash = <T>(
  boundary: string[],
  graceHandler: GraceHandler,
  onPut: (k: string, v: T) => void = () => {},
  onRemove: (k: string) => void = () => {},
                Severity: Minor
                Found in client/src/common/utils/flash.ts - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                export const useMultiHttpHttpTask = <
  I extends SerializableObject,
  O extends SerializableObject
>(
  endpointList: HttpEndpoint<I, O> | HttpAuthEndpoint<I, O>,
                Severity: Major
                Found in client/src/common/utils/http_http.ts and 1 other location - About 3 hrs to fix
                client/src/common/utils/http_get.ts on lines 97..108

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 113.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                export const useMultiHttpGetTask = <
  I extends FlatObject,
  O extends SerializableObject
>(
  endpointList: GetEndpoint<I, O> | GetAuthEndpoint<I, O>,
                Severity: Major
                Found in client/src/common/utils/http_get.ts and 1 other location - About 3 hrs to fix
                client/src/common/utils/http_http.ts on lines 103..114

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 113.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                File rail.ts has 322 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                import { Monitorable, MonitorContainer } from "interfaces/monitor";
import {
  AnimatedSpriteProperty,
  cursorOpts,
  AnimatedSpriteContainerProperty
                Severity: Minor
                Found in client/src/models/rail.ts - About 3 hrs to fix
                  Severity
                  Category
                  Status
                  Source
                  Language