Sign upLogin

yast/yast-bootloader

View on GitHub
Star
src/lib/bootloader/device_map_dialog.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Class DeviceMapDialog has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

  class DeviceMapDialog
    include Yast::UIShortcuts
    include Yast::I18n

    def self.run(device_map)
Severity: Minor
Found in src/lib/bootloader/device_map_dialog.rb - About 2 hrs to fix

    Method controller_loop has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def controller_loop
      loop do
        input = Yast::UI.UserInput
        pos = selected_disk_index
        case input
    Severity: Minor
    Found in src/lib/bootloader/device_map_dialog.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method controller_loop has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def controller_loop
      loop do
        input = Yast::UI.UserInput
        pos = selected_disk_index
        case input
    Severity: Minor
    Found in src/lib/bootloader/device_map_dialog.rb - About 1 hr to fix

      Method handle_buttons has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def handle_buttons(action, pos)
      case action
      when :up
        disks.insert(pos - 1, disks.delete_at(pos))
        pos -= 1
      Severity: Minor
      Found in src/lib/bootloader/device_map_dialog.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status