Sign upLogin

yast/yast-docker

View on GitHub
Star

Showing 5 of 5 total issues

Class MainDialog has 30 methods (exceeds 20 allowed). Consider refactoring.
Open

  class MainDialog
    include Yast::UIShortcuts
    include Yast::I18n
    include Yast::Logger
Severity: Minor
Found in src/lib/ydocker/main_dialog.rb - About 3 hrs to fix

    File main_dialog.rb has 288 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require "yast"
require "docker"
require "y2storage"

require "ydocker/changes_dialog"
    Severity: Minor
    Found in src/lib/ydocker/main_dialog.rb - About 2 hrs to fix

      Class RunImageDialog has 21 methods (exceeds 20 allowed). Consider refactoring.
      Open

        class RunImageDialog
    include Yast::UIShortcuts
    include Yast::I18n
    extend Yast::I18n
      Severity: Minor
      Found in src/lib/ydocker/run_image_dialog.rb - About 2 hrs to fix

        Method controller_loop has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def controller_loop
      loop do
        input = Yast::UI.UserInput
        handle_docker_exceptions do
          case input
        Severity: Minor
        Found in src/lib/ydocker/main_dialog.rb - About 1 hr to fix

          Method ensure_docker_run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def ensure_docker_run
      return true if Yast::Service.active?("docker")

      # Only root can start process
      if Process::UID.rid == 0
          Severity: Minor
          Found in src/lib/ydocker/main_dialog.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language