Sign upLogin

yast/yast-installation

View on GitHub
Star
src/lib/installation/clients/ssh_import_auto.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method export has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def export
      ret = {}
      # Taking values from AutoYast configuration module, otherwise do not export (bsc#1172749)
      if Mode.config
        if ssh_importer.device && !ssh_importer.device.empty?
Severity: Minor
Found in src/lib/installation/clients/ssh_import_auto.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method import has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def import(data)
      if !data["import"]
        log.info "Do not import ssh keys/configuration"
        ssh_importer.device = nil # do not copy ssh keys into the installed system
        return true
Severity: Minor
Found in src/lib/installation/clients/ssh_import_auto.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status