Sign upLogin

yast/yast-migration

View on GitHub
Star

Showing 3 of 3 total issues

Class MainWorkflow has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

  class MainWorkflow
    include Yast::Logger
    include Yast::I18n

    FIND_CONFIG_CMD = "/usr/bin/snapper --no-dbus --csvout list-configs " \
Severity: Minor
Found in src/lib/migration/main_workflow.rb - About 2 hrs to fix

    File main_workflow.rb has 256 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require "yast"

Yast.import "Mode"
Yast.import "Sequencer"
Yast.import "Update"
    Severity: Minor
    Found in src/lib/migration/main_workflow.rb - About 2 hrs to fix

      Method online_update has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def online_update
      return :abort unless init_pkg_mgmt

      patches = Patches.new
      return :next unless patches.available?
      Severity: Minor
      Found in src/lib/migration/main_workflow.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language