Sign upLogin

yast/yast-network

View on GitHub
Star
src/lib/y2network/proposal_settings.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Class ProposalSettings has 27 methods (exceeds 20 allowed). Consider refactoring.
Open

  class ProposalSettings
    include Yast::Logger
    include Yast::I18n

    # @return [Symbol] network service to be used after the installation (:wicked, :network_manager
Severity: Minor
Found in src/lib/y2network/proposal_settings.rb - About 3 hrs to fix

    Method apply_defaults has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def apply_defaults
      return if defaults_applied
      return @defaults_applied = true if DEFAULTS.all? { |o| public_send(o).nil? }

      Yast::Lan.read_config(report: false) unless yast_config
    Severity: Minor
    Found in src/lib/y2network/proposal_settings.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method network_service has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def network_service
      case current_backend
      when :network_manager
        return :network_manager if network_manager_installed?
    Severity: Minor
    Found in src/lib/y2network/proposal_settings.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return :network_manager
    Severity: Major
    Found in src/lib/y2network/proposal_settings.rb - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status