Sign upLogin

yast/yast-network

View on GitHub
Star
src/lib/y2network/widgets/boot_protocol.rb

Summary

Maintainability
D
1 day
Test Coverage

File boot_protocol.rb has 289 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require "yast"
require "cwm/custom_widget"

require "y2network/boot_protocol"
Severity: Minor
Found in src/lib/y2network/widgets/boot_protocol.rb - About 2 hrs to fix

    Method contents has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def contents
        RadioButtonGroup(
          Id(:bootproto),
          VBox(
            Left(
    Severity: Major
    Found in src/lib/y2network/widgets/boot_protocol.rb - About 2 hrs to fix

      Method validate has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def validate
        return true if value != :bootproto_static

        ipa = Yast::UI.QueryWidget(:bootproto_ipaddr, :Value)
        if !Yast::IP.Check(ipa)
      Severity: Minor
      Found in src/lib/y2network/widgets/boot_protocol.rb - About 1 hr to fix

        Method init has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def init
        case @settings.boot_protocol
        when Y2Network::BootProtocol::STATIC
          Yast::UI.ChangeWidget(Id(:bootproto), :CurrentButton, :bootproto_static)
          Yast::UI.ChangeWidget(
        Severity: Minor
        Found in src/lib/y2network/widgets/boot_protocol.rb - About 1 hr to fix

          Method store has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def store
        # FIXME: this value reset should be in backend in general not Yast::UI responsibility
        @settings.ip_address = ""
        @settings.subnet_prefix = ""
        case value
          Severity: Minor
          Found in src/lib/y2network/widgets/boot_protocol.rb - About 1 hr to fix

            Method validate has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                  def validate
        return true if value != :bootproto_static

        ipa = Yast::UI.QueryWidget(:bootproto_ipaddr, :Value)
        if !Yast::IP.Check(ipa)
            Severity: Minor
            Found in src/lib/y2network/widgets/boot_protocol.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method help has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  def help
        res = _(
          "<p><b><big>Address Setup</big></b></p>\n" \
          "<p>Select <b>No Address Setup</b> if you do not want " \
          "to assign an IP address to this device.\n" \
            Severity: Minor
            Found in src/lib/y2network/widgets/boot_protocol.rb - About 1 hr to fix

              Avoid too many return statements within this method.
              Open

                          return false
              Severity: Major
              Found in src/lib/y2network/widgets/boot_protocol.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                          return false
                Severity: Major
                Found in src/lib/y2network/widgets/boot_protocol.rb - About 30 mins to fix

                  Method handle has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                        def handle
        case value
        when :bootproto_static
          static_enabled(true)
          dynamic_enabled(false)
                  Severity: Minor
                  Found in src/lib/y2network/widgets/boot_protocol.rb - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method valid_netmask has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                        def valid_netmask(ip, mask)
        mask = mask[1..-1] if mask.start_with?("/")

        if Yast::IP.Check4(ip) && (Yast::Netmask.Check4(mask) || Yast::Netmask.CheckPrefix4(mask))
          return true
                  Severity: Minor
                  Found in src/lib/y2network/widgets/boot_protocol.rb - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method store has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                        def store
        # FIXME: this value reset should be in backend in general not Yast::UI responsibility
        @settings.ip_address = ""
        @settings.subnet_prefix = ""
        case value
                  Severity: Minor
                  Found in src/lib/y2network/widgets/boot_protocol.rb - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                          when Y2Network::BootProtocol::DHCP
          Yast::UI.ChangeWidget(Id(:bootproto), :CurrentButton, :bootproto_dynamic)
          Yast::UI.ChangeWidget(Id(:bootproto_dhcp_mode), :Value, :bootproto_dhcp_both)
          Yast::UI.ChangeWidget(Id(:bootproto_dyn), :Value, :bootproto_dhcp)
                  Severity: Minor
                  Found in src/lib/y2network/widgets/boot_protocol.rb and 2 other locations - About 15 mins to fix
                  src/lib/y2network/widgets/boot_protocol.rb on lines 128..131
                  src/lib/y2network/widgets/boot_protocol.rb on lines 132..135

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 26.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                          when Y2Network::BootProtocol::DHCP4
          Yast::UI.ChangeWidget(Id(:bootproto), :CurrentButton, :bootproto_dynamic)
          Yast::UI.ChangeWidget(Id(:bootproto_dhcp_mode), :Value, :bootproto_dhcp_v4)
          Yast::UI.ChangeWidget(Id(:bootproto_dyn), :Value, :bootproto_dhcp)
                  Severity: Minor
                  Found in src/lib/y2network/widgets/boot_protocol.rb and 2 other locations - About 15 mins to fix
                  src/lib/y2network/widgets/boot_protocol.rb on lines 124..127
                  src/lib/y2network/widgets/boot_protocol.rb on lines 132..135

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 26.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                          when Y2Network::BootProtocol::DHCP6
          Yast::UI.ChangeWidget(Id(:bootproto), :CurrentButton, :bootproto_dynamic)
          Yast::UI.ChangeWidget(Id(:bootproto_dhcp_mode), :Value, :bootproto_dhcp_v6)
          Yast::UI.ChangeWidget(Id(:bootproto_dyn), :Value, :bootproto_dhcp)
                  Severity: Minor
                  Found in src/lib/y2network/widgets/boot_protocol.rb and 2 other locations - About 15 mins to fix
                  src/lib/y2network/widgets/boot_protocol.rb on lines 124..127
                  src/lib/y2network/widgets/boot_protocol.rb on lines 128..131

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 26.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status