Sign upLogin

yast/yast-registration

View on GitHub
Star
src/lib/registration/clients/scc_auto.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Class SCCAuto has 27 methods (exceeds 20 allowed). Consider refactoring.
Open

    class SCCAuto < ::Installation::AutoClient
      include Yast::Logger
      extend Yast::I18n

      # popup message
Severity: Minor
Found in src/lib/registration/clients/scc_auto.rb - About 3 hrs to fix

    Method write has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

          def write
        # registration disabled, nothing to do
        return true if !@config.do_registration && !Yast::Mode.update

        # initialize libzypp if applying settings in installed system or
    Severity: Minor
    Found in src/lib/registration/clients/scc_auto.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method set_registration_url has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def set_registration_url
        # set the registration URL
        url = @config.reg_server if @config.reg_server && !@config.reg_server.empty?

        # use SLP discovery
    Severity: Minor
    Found in src/lib/registration/clients/scc_auto.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return false unless ret
    Severity: Major
    Found in src/lib/registration/clients/scc_auto.rb - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status