Sign upLogin

yast/yast-registration

View on GitHub
Star
src/lib/registration/url_helpers.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method reg_url_at_upgrade has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def self.reg_url_at_upgrade
      # in online upgrade mode behave like in installed system
      return reg_url_at_running_system if Yast::Installation.destdir == "/"

      custom_url = ::Registration::Storage::InstallationOptions.instance.custom_url
Severity: Minor
Found in src/lib/registration/url_helpers.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

            return old_conf.stripped_url.to_s
Severity: Major
Found in src/lib/registration/url_helpers.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                return nil if old_conf.ncc?
    Severity: Major
    Found in src/lib/registration/url_helpers.rb - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status