Sign upLogin

yast/yast-yast2

View on GitHub
Star
library/general/src/lib/yast2/popup.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method handle_event has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def handle_event(res, details, remaining_time, focus)
        case res
        when :__details
          show(details)
          nil
Severity: Minor
Found in library/general/src/lib/yast2/popup.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check_arguments! has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def check_arguments!(message, details, timeout, focus, buttons)
Severity: Minor
Found in library/general/src/lib/yast2/popup.rb - About 35 mins to fix

    Method event_loop has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def event_loop(content, focus, timeout, details, style)
    Severity: Minor
    Found in library/general/src/lib/yast2/popup.rb - About 35 mins to fix

      Method event_loop has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def event_loop(content, focus, timeout, details, style)
        res = Yast::UI.OpenDialog(dialog_options(style), content)
        raise "Failed to open dialog, see logs." unless res

        begin
      Severity: Minor
      Found in library/general/src/lib/yast2/popup.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status