Sign upLogin

yast/yast-yast2

View on GitHub
Star
library/network/src/lib/y2firewall/firewalld.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Class Firewalld has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Firewalld
    include Singleton
    include Yast::Logger
    extend Forwardable
    extend Relations
Severity: Minor
Found in library/network/src/lib/y2firewall/firewalld.rb - About 2 hrs to fix

    Method apply_zones_changes! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def apply_zones_changes!
      zones.each do |zone|
        api.create_zone(zone.name) unless current_zone_names.include?(zone.name)
        zone.apply_changes! if zone.modified?
      end
    Severity: Minor
    Found in library/network/src/lib/y2firewall/firewalld.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status