Sign upLogin

yast/yast-yast2

View on GitHub
Star
library/network/src/lib/y2firewall/firewalld/relations.rb

Summary

Maintainability
C
1 day
Test Coverage

Method has_many has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

      def has_many(*relations, scope: nil, cache: false) # rubocop:disable Naming/PredicateName
        scope = "#{scope}_" if scope
        enable_modifications_cache if cache

        define_method "relations" do
Severity: Minor
Found in library/network/src/lib/y2firewall/firewalld/relations.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method has_attributes has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

      def has_attributes(*attributes, scope: nil, cache: false) # rubocop:disable Naming/PredicateName
        scope_method = scope ? "#{scope}_" : ""
        enable_modifications_cache if cache
        define_method "attributes" do
          attributes
Severity: Minor
Found in library/network/src/lib/y2firewall/firewalld/relations.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method has_many has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def has_many(*relations, scope: nil, cache: false) # rubocop:disable Naming/PredicateName
        scope = "#{scope}_" if scope
        enable_modifications_cache if cache

        define_method "relations" do
Severity: Major
Found in library/network/src/lib/y2firewall/firewalld/relations.rb - About 2 hrs to fix

    Method has_attributes has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def has_attributes(*attributes, scope: nil, cache: false) # rubocop:disable Naming/PredicateName
        scope_method = scope ? "#{scope}_" : ""
        enable_modifications_cache if cache
        define_method "attributes" do
          attributes
    Severity: Minor
    Found in library/network/src/lib/y2firewall/firewalld/relations.rb - About 1 hr to fix

      Method enable_modifications_cache has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def enable_modifications_cache
        # Return an array with all the modified attributes/relations
        define_method "modified" do
          @modified ||= []
        end
      Severity: Minor
      Found in library/network/src/lib/y2firewall/firewalld/relations.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status