Sign upLogin

yast/yast-yast2

View on GitHub
Star
library/network/src/modules/Internet.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method Start has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def Start(log)
      if (@type == "dsl" && @capi_adsl) || @type == "isdn"
        status = Service.Status("isdn")
        Builtins.y2milestone("We need ISDN service, status: %1", status)
        if status != 0 && !Service.Start("isdn")
Severity: Minor
Found in library/network/src/modules/Internet.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Start has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def Start(log)
      if (@type == "dsl" && @capi_adsl) || @type == "isdn"
        status = Service.Status("isdn")
        Builtins.y2milestone("We need ISDN service, status: %1", status)
        if status != 0 && !Service.Start("isdn")
Severity: Minor
Found in library/network/src/modules/Internet.rb - About 1 hr to fix

    Method ShutdownAllLocalDHCPClients has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def ShutdownAllLocalDHCPClients
      pid_directory = "/var/run/"

      dhcp_pidfiles = Convert.convert(
        WFM.Read(path(".local.dir"), pid_directory),
    Severity: Minor
    Found in library/network/src/modules/Internet.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status