Sign upLogin

yast/yast-yast2

View on GitHub
Star
library/network/src/modules/NetworkPopup.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method ChooseItem has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def ChooseItem(_title, items, selected)
      items = deep_copy(items)
      item = nil

      items = Builtins.maplist(items) do |i|
Severity: Major
Found in library/network/src/modules/NetworkPopup.rb - About 2 hrs to fix

    Method ChooseItem has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        def ChooseItem(_title, items, selected)
      items = deep_copy(items)
      item = nil

      items = Builtins.maplist(items) do |i|
    Severity: Minor
    Found in library/network/src/modules/NetworkPopup.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method ChooseItemSimple has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def ChooseItemSimple(title, items, selected)
      items = deep_copy(items)
      item = nil

      items = Builtins.maplist(items) { |i| Item(Id(i), i, i == selected) }
    Severity: Minor
    Found in library/network/src/modules/NetworkPopup.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status