Sign upLogin

yast/yast-yast2

View on GitHub
Star
library/packages/src/modules/PackageLock.rb

Summary

Maintainability
C
1 day
Test Coverage

Method Connect has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    def Connect(show_continue_button)
      # we already have a lock
      return { "connected" => @have_lock, "aborted" => @aborted } if !@have_lock.nil?

      try_again = true
Severity: Minor
Found in library/packages/src/modules/PackageLock.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Connect has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def Connect(show_continue_button)
      # we already have a lock
      return { "connected" => @have_lock, "aborted" => @aborted } if !@have_lock.nil?

      try_again = true
Severity: Major
Found in library/packages/src/modules/PackageLock.rb - About 2 hrs to fix

    Method Check has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        def Check
      # we already have a lock
      return @have_lock if !@have_lock.nil?

      # just to allow 'Retry', see more in bug #280383
    Severity: Minor
    Found in library/packages/src/modules/PackageLock.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method Check has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def Check
      # we already have a lock
      return @have_lock if !@have_lock.nil?

      # just to allow 'Retry', see more in bug #280383
    Severity: Minor
    Found in library/packages/src/modules/PackageLock.rb - About 1 hr to fix

      Method AskPackageKit has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def AskPackageKit
      ret = false

      if PackageKit.IsRunning
        # ask to send quit signal to PackageKit
      Severity: Minor
      Found in library/packages/src/modules/PackageLock.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status