Sign upLogin

yast/yast-yast2

View on GitHub
Star
library/packages/src/modules/Product.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method FindBaseProducts has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def FindBaseProducts
      return unless load_zypp

      log.info "Looking for base products"
Severity: Minor
Found in library/packages/src/modules/Product.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method FindBaseProducts has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def FindBaseProducts
      return unless load_zypp

      log.info "Looking for base products"
Severity: Minor
Found in library/packages/src/modules/Product.rb - About 1 hr to fix

    Method load_product_data has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def load_product_data(key)
      @product ||= {}

      current_value = get_property(key)
      # Already loaded
    Severity: Minor
    Found in library/packages/src/modules/Product.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method set_property has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def set_property(key, value)
      current_value = get_property(key)

      # Redefining already existent information
      if !current_value.nil? && !current_value.empty? && current_value != value
    Severity: Minor
    Found in library/packages/src/modules/Product.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status