Sign upLogin

yast/yast-yast2

View on GitHub
Star
library/system/src/include/hwinfo/classnames.rb

Summary

Maintainability
C
1 day
Test Coverage

Method initialize_hwinfo_classnames has 217 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def initialize_hwinfo_classnames(_include_target)
      textdomain "base"

      # Class names collected
      @ClassNames = {
Severity: Major
Found in library/system/src/include/hwinfo/classnames.rb - About 1 day to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            11  => {
          "name" => _("Processor"),
          0      => _("386"),
          1      => _("486"),
          2      => _("Pentium"),
    Severity: Minor
    Found in library/system/src/include/hwinfo/classnames.rb and 3 other locations - About 15 mins to fix
    library/system/src/include/hwinfo/classnames.rb on lines 56..64
    library/system/src/include/hwinfo/classnames.rb on lines 142..150
    library/system/src/include/hwinfo/classnames.rb on lines 186..194

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            2   => {
          "name" => _("Network controller"),
          0      => _("Ethernet controller"),
          1      => _("Token ring network controller"),
          2      => _("FDDI network controller"),
    Severity: Minor
    Found in library/system/src/include/hwinfo/classnames.rb and 3 other locations - About 15 mins to fix
    library/system/src/include/hwinfo/classnames.rb on lines 132..140
    library/system/src/include/hwinfo/classnames.rb on lines 142..150
    library/system/src/include/hwinfo/classnames.rb on lines 186..194

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            12  => {
          "name" => _("Serial bus controller"),
          0      => _("FireWire (IEEE 1394)"),
          1      => _("ACCESS bus"),
          2      => _("SSA"),
    Severity: Minor
    Found in library/system/src/include/hwinfo/classnames.rb and 3 other locations - About 15 mins to fix
    library/system/src/include/hwinfo/classnames.rb on lines 56..64
    library/system/src/include/hwinfo/classnames.rb on lines 132..140
    library/system/src/include/hwinfo/classnames.rb on lines 186..194

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            257 => {
          "name" => _("Internally used class"),
          1      => _("ISA PnP interface"),
          2      => _("Main memory"),
          3      => _("CPU"),
    Severity: Minor
    Found in library/system/src/include/hwinfo/classnames.rb and 3 other locations - About 15 mins to fix
    library/system/src/include/hwinfo/classnames.rb on lines 56..64
    library/system/src/include/hwinfo/classnames.rb on lines 132..140
    library/system/src/include/hwinfo/classnames.rb on lines 142..150

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status