Sign upLogin

yast/yast-yast2

View on GitHub
Star
library/system/src/modules/Initrd.rb

Summary

Maintainability
D
1 day
Test Coverage

Method AddModule has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    def AddModule(modname, modargs)
      log.warn "Initrd.AddModule() is deprecated, do not use (sysconfig.kernel.INITRD_MODULES " \
               "is not written anymore, see bnc#895084)"

      if Stage.initial && Builtins.size(@modules) == 0
Severity: Minor
Found in library/system/src/modules/Initrd.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Initrd.rb has 267 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require "yast"
require "shellwords"

module Yast
  class InitrdClass < Module
Severity: Minor
Found in library/system/src/modules/Initrd.rb - About 2 hrs to fix

    Method Write has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def Write
      Read() if !(@was_read || Mode.config)
      Update() if Mode.update
      Builtins.y2milestone(
        "Initrd::Write called, changed: %1, list: %2",
    Severity: Major
    Found in library/system/src/modules/Initrd.rb - About 2 hrs to fix

      Method Write has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          def Write
      Read() if !(@was_read || Mode.config)
      Update() if Mode.update
      Builtins.y2milestone(
        "Initrd::Write called, changed: %1, list: %2",
      Severity: Minor
      Found in library/system/src/modules/Initrd.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method AddModule has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def AddModule(modname, modargs)
      log.warn "Initrd.AddModule() is deprecated, do not use (sysconfig.kernel.INITRD_MODULES " \
               "is not written anymore, see bnc#895084)"

      if Stage.initial && Builtins.size(@modules) == 0
      Severity: Minor
      Found in library/system/src/modules/Initrd.rb - About 1 hr to fix

        Method main has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def main
      Yast.import "UI"

      Yast.import "Arch"
      Yast.import "Label"
        Severity: Minor
        Found in library/system/src/modules/Initrd.rb - About 1 hr to fix

          There are no issues that match your filters.

          Category
          Status