Sign upLogin

yast/yast-yast2

View on GitHub
Star
library/system/src/modules/ModuleLoading.rb

Summary

Maintainability
D
1 day
Test Coverage

Method Load has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

    def Load(modulename, moduleargs, vendorname, devicename, ask_before_loading, with_modprobe)
      if modulename != "" &&
          # there is no reason for checking initrd, if I need the module to get loaded, I just  need to
          # check if it isn't already loaded
          #      && (!contains (Initrd::ListModules (), modulename))
Severity: Minor
Found in library/system/src/modules/ModuleLoading.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Load has 114 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def Load(modulename, moduleargs, vendorname, devicename, ask_before_loading, with_modprobe)
      if modulename != "" &&
          # there is no reason for checking initrd, if I need the module to get loaded, I just  need to
          # check if it isn't already loaded
          #      && (!contains (Initrd::ListModules (), modulename))
Severity: Major
Found in library/system/src/modules/ModuleLoading.rb - About 4 hrs to fix

    Method prepareVendorDeviceInfo has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def prepareVendorDeviceInfo(controller)
      controller = deep_copy(controller)
      # build up vendor/device information

      # if vendor not given, try sub_vendor
    Severity: Minor
    Found in library/system/src/modules/ModuleLoading.rb - About 1 hr to fix

      Method Load has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def Load(modulename, moduleargs, vendorname, devicename, ask_before_loading, with_modprobe)
      Severity: Minor
      Found in library/system/src/modules/ModuleLoading.rb - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                      module_data = Builtins.substring(module_data, firstspace) if !firstspace.nil?
        Severity: Major
        Found in library/system/src/modules/ModuleLoading.rb - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                        if firstspace.nil?
                modulename = module_data
                moduleargs = ""
              else
                modulename = Builtins.substring(module_data, 0, firstspace)
          Severity: Major
          Found in library/system/src/modules/ModuleLoading.rb - About 45 mins to fix

            Method prepareVendorDeviceInfo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def prepareVendorDeviceInfo(controller)
      controller = deep_copy(controller)
      # build up vendor/device information

      # if vendor not given, try sub_vendor
            Severity: Minor
            Found in library/system/src/modules/ModuleLoading.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  if controller_device != ""
        controller_sub_device = Ops.get_string(controller, "sub_device", "")
        if controller_sub_device != ""
          controller_device = Ops.add(
            Ops.add(Ops.add(controller_device, "\n("), controller_sub_device),
            Severity: Minor
            Found in library/system/src/modules/ModuleLoading.rb and 1 other location - About 15 mins to fix
            library/system/src/modules/ModuleLoading.rb on lines 67..72

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 26.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  if controller_vendor != ""
        controller_sub_vendor = Ops.get_string(controller, "sub_vendor", "")
        if controller_sub_vendor != ""
          controller_vendor = Ops.add(
            Ops.add(Ops.add(controller_vendor, "\n("), controller_sub_vendor),
            Severity: Minor
            Found in library/system/src/modules/ModuleLoading.rb and 1 other location - About 15 mins to fix
            library/system/src/modules/ModuleLoading.rb on lines 84..89

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 26.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status