Sign upLogin

yasyf/vc

View on GitHub
Star
app/jobs/card_sync_job.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Cyclomatic complexity for perform is too high. [20/6]
Open

  def perform(team, card_data, deep: false, quiet: true)
    card_data = card_data.with_indifferent_access

    list = List.where(trello_id: card_data.delete(:trello_list_id)).first!
    card = Card.where(trello_id: card_data[:trello_id]).first_or_initialize
Severity: Minor
Found in app/jobs/card_sync_job.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method perform has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

  def perform(team, card_data, deep: false, quiet: true)
    card_data = card_data.with_indifferent_access

    list = List.where(trello_id: card_data.delete(:trello_list_id)).first!
    card = Card.where(trello_id: card_data[:trello_id]).first_or_initialize
Severity: Minor
Found in app/jobs/card_sync_job.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method has too many lines. [31/30]
Open

  def perform(team, card_data, deep: false, quiet: true)
    card_data = card_data.with_indifferent_access

    list = List.where(trello_id: card_data.delete(:trello_list_id)).first!
    card = Card.where(trello_id: card_data[:trello_id]).first_or_initialize
Severity: Minor
Found in app/jobs/card_sync_job.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method users_from_card_data has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  def users_from_card_data(team, card)
    card.members.map do |member|
      User.from_trello(member.id).tap do |user|
        if user.present?
          user.team ||= team
Severity: Minor
Found in app/jobs/card_sync_job.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method perform has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def perform(team, card_data, deep: false, quiet: true)
    card_data = card_data.with_indifferent_access

    list = List.where(trello_id: card_data.delete(:trello_list_id)).first!
    card = Card.where(trello_id: card_data[:trello_id]).first_or_initialize
Severity: Minor
Found in app/jobs/card_sync_job.rb - About 1 hr to fix

Method try_save! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def try_save!(company)
    if company.changed?
      begin
        company.save!
      rescue ActiveRecord::RecordInvalid, ActiveRecord::RecordNotUnique => e
Severity: Minor
Found in app/jobs/card_sync_job.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status