Sign upLogin

yasyf/vc

View on GitHub
Star

Showing 594 of 594 total issues

end at 219, 4 is not aligned with if at 215, 12.
Open

    end
Severity: Minor
Found in app/controllers/external/api/v1/messages_controller.rb by rubocop

This cop checks whether the end keywords are aligned properly.

Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

Example: EnforcedStyleAlignWith: keyword (default)

# bad

variable = if true
    end

# good

variable = if true
           end

Example: EnforcedStyleAlignWith: variable

# bad

variable = if true
    end

# good

variable = if true
end

Example: EnforcedStyleAlignWith: startofline

# bad

variable = if true
    end

# good

puts(if true
end)

end at 136, 4 is not aligned with if at 132, 12.
Open

    end
Severity: Minor
Found in lib/message.rb by rubocop

This cop checks whether the end keywords are aligned properly.

Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

Example: EnforcedStyleAlignWith: keyword (default)

# bad

variable = if true
    end

# good

variable = if true
           end

Example: EnforcedStyleAlignWith: variable

# bad

variable = if true
    end

# good

variable = if true
end

Example: EnforcedStyleAlignWith: startofline

# bad

variable = if true
    end

# good

puts(if true
end)

Unused method argument - attrs. If it's necessary, use _ or _attrs as an argument name to indicate that it won't be used. You can also write as _eligible?(*) if you want the method to accept any arguments but don't care about them.
Open

  def self._eligible?(attrs)
Severity: Minor
Found in lib/competitor_lists/most_popular_global.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Unused method argument - attrs. If it's necessary, use _ or _attrs as an argument name to indicate that it won't be used. You can also write as _eligible?(*) if you want the method to accept any arguments but don't care about them.
Open

  def self._eligible?(attrs)
Severity: Minor
Found in lib/competitor_lists/single.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Unused block argument - request. You can omit the argument if you don't care about it.
Open

        fund_type: Proc.new { |request| fund_type }
Severity: Minor
Found in lib/competitor_lists/most_popular_of.rb by rubocop

This cop checks for unused block arguments.

Example:

# bad

do_something do |used, unused|
  puts used
end

do_something do |bar|
  puts :foo
end

define_method(:foo) do |bar|
  puts :baz
end

Example:

#good

do_something do |used, _unused|
  puts used
end

do_something do
  puts :foo
end

define_method(:foo) do |_bar|
  puts :baz
end

Do not suppress exceptions.
Open

    rescue Curl::Err::MultiBadEasyHandle
Severity: Minor
Found in lib/http/fetch.rb by rubocop

This cop checks for rescue blocks with no body.

Example:

# bad

def some_method
  do_something
rescue
  # do nothing
end

Example:

# bad

begin
  do_something
rescue
  # do nothing
end

Example:

# good

def some_method
  do_something
rescue
  handle_exception
end

Example:

# good

begin
  do_something
rescue
  handle_exception
end

Unused block argument - t. If it's necessary, use _ or _t as an argument name to indicate that it won't be used.
Open

  task :csv, [:url, :team] => [:environment] do |t, args|
Severity: Minor
Found in lib/tasks/sync.rake by rubocop

This cop checks for unused block arguments.

Example:

# bad

do_something do |used, unused|
  puts used
end

do_something do |bar|
  puts :foo
end

define_method(:foo) do |bar|
  puts :baz
end

Example:

#good

do_something do |used, _unused|
  puts used
end

do_something do
  puts :foo
end

define_method(:foo) do |_bar|
  puts :baz
end

Unused block argument - k. If it's necessary, use _ or _k as an argument name to indicate that it won't be used.
Open

      scope = Investor.where(row.except(:email).select {|k,v| v.present? })
Severity: Minor
Found in lib/importers/external/investor_emails.rb by rubocop

This cop checks for unused block arguments.

Example:

# bad

do_something do |used, unused|
  puts used
end

do_something do |bar|
  puts :foo
end

define_method(:foo) do |bar|
  puts :baz
end

Example:

#good

do_something do |used, _unused|
  puts used
end

do_something do
  puts :foo
end

define_method(:foo) do |_bar|
  puts :baz
end

Do not suppress exceptions.
Open

  rescue Trello::Error
Severity: Minor
Found in app/models/card.rb by rubocop

This cop checks for rescue blocks with no body.

Example:

# bad

def some_method
  do_something
rescue
  # do nothing
end

Example:

# bad

begin
  do_something
rescue
  # do nothing
end

Example:

# good

def some_method
  do_something
rescue
  handle_exception
end

Example:

# good

begin
  do_something
rescue
  handle_exception
end

Ambiguous splat operator. Parenthesize the method arguments if it's surely a splat operator, or add a whitespace to the right of the * if it should be a multiplication.
Open

    from_username_domain *email.split('@')
Severity: Minor
Found in app/models/user.rb by rubocop

This cop checks for ambiguous operators in the first argument of a method invocation without parentheses.

Example:

# bad

# The `*` is interpreted as a splat operator but it could possibly be
# a `*` method invocation (i.e. `do_something.*(some_array)`).
do_something *some_array

Example:

# good

# With parentheses, there's no ambiguity.
do_something(*some_array)

Unreachable code detected.
Open

      @data.present? && @data['id'].present?
Severity: Minor
Found in lib/http/angel_list/base.rb by rubocop

This cop checks for unreachable code. The check are based on the presence of flow of control statement in non-final position in begin(implicit) blocks.

Example:

# bad

def some_method
  return
  do_something
end

# bad

def some_method
  if cond
    return
  else
    return
  end
  do_something
end

Example:

# good

def some_method
  do_something
end

TODO found
Open

      return false # TODO: re-enable AL API
Severity: Minor
Found in lib/http/angel_list/base.rb by fixme

TODO found
Open

    #TODO: do this in sql
Severity: Minor
Found in app/jobs/propagate_industry_up_job.rb by fixme

TODO found
Open

    #TODO: do this in sql
Severity: Minor
Found in app/jobs/propagate_fund_type_up_job.rb by fixme
Severity
Category
Status
Source
Language