Method upload
has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring. Open
def upload(file, source: '')
deliveries = Deliveries.new(pgsql: @pgsql)
line = 1
File.readlines(file).each do |t|
begin
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method add
has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
def add(email, first: '', last: '', source: '')
raise UserError, "Invalid email #{email.inspect}" unless email =~ Recipients::REGEX
recipient = Recipient.new(
id: @pgsql.exec(
'INSERT INTO recipient (list, email, first, last, source) VALUES ($1, $2, $3, $4, $5) RETURNING id',
Method all
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def all(query: '', limit: 100, active_only: false, in_list_only: true)
q = [
'SELECT recipient.* FROM recipient',
'JOIN list ON list.id = recipient.list AND list.owner = $1',
'WHERE',
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method upload
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
def upload(file, source: '')
deliveries = Deliveries.new(pgsql: @pgsql)
line = 1
File.readlines(file).each do |t|
begin
Method csv
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def csv
CSV.generate(headers: true) do |csv|
csv << [
'Email',
'First name',
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method add
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def add(email, first: '', last: '', source: '')
raise UserError, "Invalid email #{email.inspect}" unless email =~ Recipients::REGEX
recipient = Recipient.new(
id: @pgsql.exec(
'INSERT INTO recipient (list, email, first, last, source) VALUES ($1, $2, $3, $4, $5) RETURNING id',
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"