Sign upLogin

yegor256/pdd

View on GitHub
Star
lib/pdd/source.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method puzzle_tail_prefix has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def puzzle_tail_prefix(lines, prefix)
      return prefix if lines.empty?
      i = 0
      while i < lines.length
        unless puzzle_empty_line?(lines[i], prefix)
Severity: Minor
Found in lib/pdd/source.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method puzzles has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def puzzles
      PDD.log.info "Reading #{@path} ..."
      puzzles = []
      lines = File.readlines(@file, encoding: 'UTF-8')
      lines.each_with_index do |line, idx|
Severity: Minor
Found in lib/pdd/source.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method tail has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def tail(lines, prefix, start)
      return [] if lines.empty?
      prefix = " #{' ' * start}" if prefix.empty? # fallback to space indentation
      tail_prefix = puzzle_tail_prefix(lines, prefix)
      tail = lines
Severity: Minor
Found in lib/pdd/source.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status